-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix](delete command) Mark delete sign when do delete command in MoW table #35917 #38468
Conversation
…table (apache#35917) close apache#34551 Problem: As shown in the issue above, if a key deleted by a delete statement is written to by updating only certain columns, the data will not display correctly. Reason: The delete statement deletes the data by writing a delete predicate, which is stored in the rowset meta and applied during data retrieval to filter the data. However, partial column updates do not consider the effect of the delete predicate when reading the original data. The imported key should be considered as a new key (since it has already been deleted), but it is actually treated as an old key. Therefore, only some columns are updated, leading to incorrect results. Solution: Consider the delete predicate during partial column updates, but this method will result in reading more columns, as shown in apache#35766. Thus, in this PR, we change the delete operation in the mow table from writing a delete predicate to writing a delete sign, which effectively resolves the issue.
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
…d mode (apache#37151) Problem: The `test_new_partial_update` case fails to run in cloud mode, but it passes in local mode. Reason: In PR apache#35917, we introduced a new table attribute `enable_light_delete`. When executing schema changes with `alter table set xxx` statements, the local and cloud modes process the logic differently. The cloud mode has its unique processing logic, which was not addressed in the mentioned PR, leading to failures in the cloud environment. Solution: To resolve the issue, we need to complete the missing schema change logic for the cloud mode. Once this is implemented, the problem should be resolved.
run buildall |
TPC-H: Total hot run time: 49440 ms
|
run buildall |
TPC-H: Total hot run time: 49844 ms
|
TPC-DS: Total hot run time: 204098 ms
|
ClickBench: Total hot run time: 31.5 s
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
run buildall |
TPC-H: Total hot run time: 49886 ms
|
TPC-DS: Total hot run time: 204111 ms
|
ClickBench: Total hot run time: 31.52 s
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
run buildall |
TPC-H: Total hot run time: 50029 ms
|
TPC-DS: Total hot run time: 204093 ms
|
ClickBench: Total hot run time: 31.16 s
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
run p0 |
Proposed changes
Pick #35917