Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](noexcept) Remove incorrect noexcept #35230

Merged
merged 1 commit into from
May 23, 2024

Conversation

zhiqiang-hhhh
Copy link
Contributor

No description provided.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 42103 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 836ddab5e2c34cb9232ae5cd785ad7bff7cde6a3, data reload: false

------ Round 1 ----------------------------------
q1	17625	4642	4305	4305
q2	2030	188	193	188
q3	10449	1258	1155	1155
q4	10187	800	844	800
q5	7486	2782	2720	2720
q6	241	134	141	134
q7	980	621	617	617
q8	9221	2186	2120	2120
q9	9377	6712	6753	6712
q10	9637	3925	3889	3889
q11	456	247	274	247
q12	452	229	244	229
q13	17349	3250	3257	3250
q14	276	210	228	210
q15	507	467	466	466
q16	501	403	404	403
q17	1013	708	709	708
q18	8581	7887	7762	7762
q19	6040	1600	1580	1580
q20	660	327	335	327
q21	5195	4054	4003	4003
q22	371	278	291	278
Total cold run time: 118634 ms
Total hot run time: 42103 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4611	4456	4447	4447
q2	382	279	284	279
q3	3157	3000	2854	2854
q4	1905	1619	1676	1619
q5	5863	5542	5518	5518
q6	216	132	135	132
q7	2170	1871	1837	1837
q8	3269	3411	3427	3411
q9	8724	8747	8623	8623
q10	3985	3848	3899	3848
q11	601	492	510	492
q12	818	630	631	630
q13	17054	3154	3205	3154
q14	306	276	286	276
q15	522	471	468	468
q16	469	412	421	412
q17	1817	1493	1497	1493
q18	7791	7711	7386	7386
q19	1669	1555	1587	1555
q20	1994	1800	1776	1776
q21	4990	4760	4722	4722
q22	568	496	489	489
Total cold run time: 72881 ms
Total hot run time: 55421 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 168362 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 836ddab5e2c34cb9232ae5cd785ad7bff7cde6a3, data reload: false

query1	903	384	378	378
query2	6452	2433	2317	2317
query3	6638	204	208	204
query4	19979	17368	17251	17251
query5	4093	429	421	421
query6	246	167	169	167
query7	4601	299	285	285
query8	240	195	185	185
query9	8474	2385	2368	2368
query10	454	279	266	266
query11	10683	10144	9968	9968
query12	135	96	86	86
query13	1647	365	375	365
query14	9331	7610	6777	6777
query15	217	171	181	171
query16	7698	261	253	253
query17	1733	523	521	521
query18	1845	273	269	269
query19	205	155	167	155
query20	93	88	88	88
query21	192	133	126	126
query22	4091	4024	3843	3843
query23	33748	32990	32789	32789
query24	11013	2829	2728	2728
query25	605	370	363	363
query26	1488	156	154	154
query27	2919	316	314	314
query28	7429	2025	2038	2025
query29	991	613	605	605
query30	235	171	173	171
query31	964	769	767	767
query32	92	53	56	53
query33	751	264	267	264
query34	968	476	462	462
query35	753	617	622	617
query36	1049	924	885	885
query37	134	70	71	70
query38	2901	2811	2762	2762
query39	858	807	804	804
query40	252	128	124	124
query41	45	44	39	39
query42	106	100	99	99
query43	587	536	502	502
query44	1270	720	750	720
query45	182	165	167	165
query46	1076	745	704	704
query47	1867	1773	1796	1773
query48	378	288	305	288
query49	932	381	378	378
query50	786	407	379	379
query51	6873	6876	6693	6693
query52	97	90	88	88
query53	355	292	275	275
query54	866	444	421	421
query55	74	71	70	70
query56	257	244	248	244
query57	1139	1053	1053	1053
query58	220	201	216	201
query59	3465	3164	3273	3164
query60	273	252	250	250
query61	95	89	89	89
query62	634	462	461	461
query63	309	282	281	281
query64	9743	2221	1724	1724
query65	3169	3068	3108	3068
query66	1046	332	326	326
query67	15167	14800	14895	14800
query68	4388	571	523	523
query69	442	269	258	258
query70	1122	1075	1106	1075
query71	423	272	277	272
query72	7846	2736	2554	2554
query73	707	314	325	314
query74	6088	5662	5639	5639
query75	3418	2630	2652	2630
query76	2752	972	869	869
query77	400	262	262	262
query78	10150	9819	9767	9767
query79	2627	532	523	523
query80	1102	439	431	431
query81	548	251	243	243
query82	777	99	99	99
query83	255	172	169	169
query84	257	91	93	91
query85	1570	398	260	260
query86	479	312	296	296
query87	3391	3146	3101	3101
query88	4352	2321	2315	2315
query89	490	408	390	390
query90	2051	189	191	189
query91	127	95	95	95
query92	67	48	50	48
query93	1924	512	496	496
query94	1194	186	184	184
query95	410	309	305	305
query96	601	266	257	257
query97	3193	3003	2977	2977
query98	243	217	218	217
query99	1077	839	837	837
Total cold run time: 272582 ms
Total hot run time: 168362 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.65% (9011/25277)
Line Coverage: 27.29% (74494/272961)
Region Coverage: 26.52% (38549/145357)
Branch Coverage: 23.38% (19667/84118)
Coverage Report: http://coverage.selectdb-in.cc/coverage/836ddab5e2c34cb9232ae5cd785ad7bff7cde6a3_836ddab5e2c34cb9232ae5cd785ad7bff7cde6a3/report/index.html

@doris-robot
Copy link

ClickBench: Total hot run time: 30.45 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 836ddab5e2c34cb9232ae5cd785ad7bff7cde6a3, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.23	0.04	0.04
query4	1.67	0.06	0.07
query5	0.49	0.49	0.50
query6	1.13	0.71	0.72
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.55	0.48	0.48
query10	0.56	0.56	0.54
query11	0.16	0.11	0.11
query12	0.14	0.12	0.12
query13	0.60	0.59	0.59
query14	0.77	0.77	0.80
query15	0.82	0.81	0.82
query16	0.36	0.37	0.37
query17	0.96	0.96	1.03
query18	0.22	0.27	0.25
query19	1.77	1.76	1.79
query20	0.02	0.01	0.01
query21	15.47	0.68	0.66
query22	4.50	7.52	1.84
query23	18.27	1.39	1.29
query24	1.55	0.33	0.24
query25	0.14	0.09	0.08
query26	0.27	0.16	0.16
query27	0.08	0.08	0.07
query28	13.27	1.03	1.00
query29	13.33	3.27	3.22
query30	0.24	0.06	0.06
query31	2.87	0.38	0.38
query32	3.29	0.46	0.47
query33	2.85	2.95	2.87
query34	17.34	4.42	4.43
query35	4.44	4.47	4.64
query36	0.65	0.46	0.51
query37	0.18	0.15	0.15
query38	0.15	0.14	0.14
query39	0.04	0.03	0.04
query40	0.15	0.14	0.14
query41	0.08	0.04	0.05
query42	0.05	0.04	0.04
query43	0.04	0.04	0.03
Total cold run time: 109.89 s
Total hot run time: 30.45 s

Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels May 22, 2024
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@zclllyybb zclllyybb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 9042661 into apache:master May 23, 2024
27 of 29 checks passed
@zhiqiang-hhhh zhiqiang-hhhh deleted the fix-nocept branch May 23, 2024 03:40
yiguolei pushed a commit that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants