Skip to content

Commit

Permalink
[fix](noexcept) Remove incorrect noexcept #35230
Browse files Browse the repository at this point in the history
  • Loading branch information
zhiqiang-hhhh authored and Doris-Extras committed May 24, 2024
1 parent 98b2bda commit 682d72b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion be/src/vec/columns/column_const.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ std::pair<const ColumnPtr&, bool> unpack_if_const(const ColumnPtr& ptr) noexcept

void default_preprocess_parameter_columns(ColumnPtr* columns, const bool* col_const,
const std::initializer_list<size_t>& parameters,
Block& block, const ColumnNumbers& arg_indexes) noexcept {
Block& block, const ColumnNumbers& arg_indexes) {
if (std::all_of(parameters.begin(), parameters.end(),
[&](size_t const_index) -> bool { return col_const[const_index]; })) {
// only need to avoid expanding when all parameters are const
Expand Down
2 changes: 1 addition & 1 deletion be/src/vec/columns/column_const.h
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ std::pair<const ColumnPtr&, bool> unpack_if_const(const ColumnPtr&) noexcept;
*/
void default_preprocess_parameter_columns(ColumnPtr* columns, const bool* col_const,
const std::initializer_list<size_t>& parameters,
Block& block, const ColumnNumbers& arg_indexes) noexcept;
Block& block, const ColumnNumbers& arg_indexes);

/** ColumnConst contains another column with single element,
* but looks like a column with arbitrary amount of same elements.
Expand Down

0 comments on commit 682d72b

Please sign in to comment.