[fix](clone) Fix clone and alter tablet use same tablet path #34889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -263,6 +263,9 @@ Status EngineCloneTask::_do_clone() { | |||
| &store, _clone_req.partition_id)); | |||
| auto tablet_dir = fmt::format("{}/{}/{}", local_shard_root_path, _clone_req.tablet_id, | |||
| _clone_req.schema_hash); | |||
| auto tablet_manager = _engine.tablet_manager(); | |||
There was a problem hiding this comment.
warning: 'auto tablet_manager' can be declared as 'auto *tablet_manager' [readability-qualified-auto]
Suggested change
| auto tablet_manager = _engine.tablet_manager(); | |
| auto *tablet_manager = _engine.tablet_manager(); |
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 172537 ms |
ClickBench: Total hot run time: 30.25 s |
|
run buildall |
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 42083 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 168084 ms |
ClickBench: Total hot run time: 30.57 s |
yujun777
reviewed
May 29, 2024
|
clang-tidy review says "All clean, LGTM! 👍" |
yujun777
reviewed
May 31, 2024
yujun777
reviewed
May 31, 2024
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 39967 ms |
TPC-DS: Total hot run time: 172966 ms |
ClickBench: Total hot run time: 30.55 s |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
TPC-H: Total hot run time: 40312 ms |
TPC-DS: Total hot run time: 172807 ms |
|
TeamCity be ut coverage result: |
ClickBench: Total hot run time: 31.16 s |
dataroaring
pushed a commit
that referenced
this pull request
Jun 7, 2024
The entire process is as follows: 1. Drop the tablet. 2. Successfully clone the tablet in full. 3. Start the incremental clone. 4. Start to move the tablet to the trash (the process of actually cleaning the data begins from step 1, where the tablet was dropped). 5. The incremental clone fails. 6. The incremental clone is successfully retried. Step 4 moved the data that was just pulled from the full clone to the trash, leading to data loss. The failure in step 5 of the incremental clone was also due to the deletion of the just-pulled snapshot data. Fix： When cloning, check the tablet status and determine if the tablet directory has already been moved to the trash directory. If it has not been moved to the trash, the clone thread should help move it to the trash directory.
deardeng
added a commit
to deardeng/incubator-doris
that referenced
this pull request
Jun 25, 2024
…34889) The entire process is as follows: 1. Drop the tablet. 2. Successfully clone the tablet in full. 3. Start the incremental clone. 4. Start to move the tablet to the trash (the process of actually cleaning the data begins from step 1, where the tablet was dropped). 5. The incremental clone fails. 6. The incremental clone is successfully retried. Step 4 moved the data that was just pulled from the full clone to the trash, leading to data loss. The failure in step 5 of the incremental clone was also due to the deletion of the just-pulled snapshot data. Fix： When cloning, check the tablet status and determine if the tablet directory has already been moved to the trash directory. If it has not been moved to the trash, the clone thread should help move it to the trash directory.
This was referenced Jun 25, 2024
deardeng
added a commit
to deardeng/incubator-doris
that referenced
this pull request
Jun 26, 2024
…34889) The entire process is as follows: 1. Drop the tablet. 2. Successfully clone the tablet in full. 3. Start the incremental clone. 4. Start to move the tablet to the trash (the process of actually cleaning the data begins from step 1, where the tablet was dropped). 5. The incremental clone fails. 6. The incremental clone is successfully retried. Step 4 moved the data that was just pulled from the full clone to the trash, leading to data loss. The failure in step 5 of the incremental clone was also due to the deletion of the just-pulled snapshot data. Fix： When cloning, check the tablet status and determine if the tablet directory has already been moved to the trash directory. If it has not been moved to the trash, the clone thread should help move it to the trash directory.
dataroaring
pushed a commit
that referenced
this pull request
Jun 26, 2024
deardeng
added a commit
to deardeng/incubator-doris
that referenced
this pull request
Jun 28, 2024
…34889) The entire process is as follows: 1. Drop the tablet. 2. Successfully clone the tablet in full. 3. Start the incremental clone. 4. Start to move the tablet to the trash (the process of actually cleaning the data begins from step 1, where the tablet was dropped). 5. The incremental clone fails. 6. The incremental clone is successfully retried. Step 4 moved the data that was just pulled from the full clone to the trash, leading to data loss. The failure in step 5 of the incremental clone was also due to the deletion of the just-pulled snapshot data. Fix： When cloning, check the tablet status and determine if the tablet directory has already been moved to the trash directory. If it has not been moved to the trash, the clone thread should help move it to the trash directory.
dataroaring
pushed a commit
that referenced
this pull request
Jun 30, 2024
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
The entire process is as follows:
Step 4 moved the data that was just pulled from the full clone to the trash, leading to data loss.
The failure in step 5 of the incremental clone was also due to the deletion of the just-pulled snapshot data.
Fix：
When cloning, check the tablet status and determine if the tablet directory has already been moved to the trash directory. If it has not been moved to the trash, the clone thread should help move it to the trash directory.
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...