Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](clone) Fix clone and alter tablet use same tablet path #34889 #36858

Merged

Conversation

deardeng
Copy link
Contributor

cherry pick from #34889

@deardeng
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@deardeng
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.37% (9157/25178)
Line Coverage: 27.89% (74677/267745)
Region Coverage: 26.80% (38516/143717)
Branch Coverage: 23.48% (19503/83078)
Coverage Report: http://coverage.selectdb-in.cc/coverage/54896d08da1b8ae503d05bf2da24dfa0a5ea9a8f_54896d08da1b8ae503d05bf2da24dfa0a5ea9a8f/report/index.html

@deardeng
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.38% (9160/25178)
Line Coverage: 27.90% (74693/267758)
Region Coverage: 26.81% (38533/143723)
Branch Coverage: 23.48% (19510/83082)
Coverage Report: http://coverage.selectdb-in.cc/coverage/2d5e1f194344ba0cb3158f9971fc583c731f3fad_2d5e1f194344ba0cb3158f9971fc583c731f3fad/report/index.html

…34889)

The entire process is as follows:
1. Drop the tablet.
2. Successfully clone the tablet in full.
3. Start the incremental clone.
4. Start to move the tablet to the trash (the process of actually
cleaning the data begins from step 1, where the tablet was dropped).
5. The incremental clone fails.
6. The incremental clone is successfully retried.

Step 4 moved the data that was just pulled from the full clone to the
trash, leading to data loss.
The failure in step 5 of the incremental clone was also due to the
deletion of the just-pulled snapshot data.

Fix:
When cloning, check the tablet status and determine if the tablet
directory has already been moved to the trash directory. If it has not
been moved to the trash, the clone thread should help move it to the
trash directory.
@deardeng deardeng force-pushed the pick_34889_to_doris_branch-2.1 branch from 2d5e1f1 to 67ab139 Compare June 28, 2024 09:36
@deardeng
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.35% (9152/25180)
Line Coverage: 27.89% (74678/267803)
Region Coverage: 26.79% (38505/143733)
Branch Coverage: 23.49% (19518/83108)
Coverage Report: http://coverage.selectdb-in.cc/coverage/67ab139b4b13843d94f15fa128cdfdc39f2190a4_67ab139b4b13843d94f15fa128cdfdc39f2190a4/report/index.html

@dataroaring dataroaring merged commit 92cbbd2 into apache:branch-2.1 Jun 30, 2024
19 of 21 checks passed
@yiguolei yiguolei mentioned this pull request Jul 19, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants