[Fix](nereids) set all nullable aggregate function to alwaysnullable …

…in window expression
apache · Sep 11, 2024 · 87cee07 · 87cee07
1 parent d736a50
commit 87cee07
Showing 1 changed file with 5 additions and 11 deletions.
diff --git a/...main/java/org/apache/doris/nereids/rules/rewrite/ExtractAndNormalizeWindowExpression.java b/...main/java/org/apache/doris/nereids/rules/rewrite/ExtractAndNormalizeWindowExpression.java
@@ -25,11 +25,7 @@
 import org.apache.doris.nereids.trees.expressions.OrderExpression;
 import org.apache.doris.nereids.trees.expressions.Slot;
 import org.apache.doris.nereids.trees.expressions.WindowExpression;
-import org.apache.doris.nereids.trees.expressions.functions.agg.Avg;
-import org.apache.doris.nereids.trees.expressions.functions.agg.Max;
-import org.apache.doris.nereids.trees.expressions.functions.agg.Min;
 import org.apache.doris.nereids.trees.expressions.functions.agg.NullableAggregateFunction;
-import org.apache.doris.nereids.trees.expressions.functions.agg.Sum;
 import org.apache.doris.nereids.trees.plans.Plan;
 import org.apache.doris.nereids.trees.plans.logical.LogicalProject;
 import org.apache.doris.nereids.trees.plans.logical.LogicalWindow;
@@ -64,13 +60,11 @@ private Plan normalize(LogicalProject<Plan> project) {
                     if (output instanceof WindowExpression) {
                         WindowExpression windowExpression = (WindowExpression) output;
                         Expression expression = ((WindowExpression) output).getFunction();
-                        if (expression instanceof Sum || expression instanceof Max
-                                || expression instanceof Min || expression instanceof Avg) {
-                            // sum, max, min and avg in window function should be always nullable
-                            windowExpression = ((WindowExpression) output)
-                                    .withFunction(
-                                            ((NullableAggregateFunction) expression).withAlwaysNullable(true)
-                                    );
+                        if (expression instanceof NullableAggregateFunction) {
+                            // NullableAggregateFunction in window function should be always nullable
+                            // Because there may be no data in the window frame, null values will be generated.
+                            windowExpression = ((WindowExpression) output).withFunction(
+                                    ((NullableAggregateFunction) expression).withAlwaysNullable(true));
                         }
 
                         ImmutableList.Builder<Expression> nonLiteralPartitionKeys =