Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to libraries-bom 26.20.0 #27725

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

bvolpato
Copy link
Contributor

@bvolpato bvolpato commented Jul 28, 2023

Update google_cloud_platform_libraries_bom to 26.20.0.

Associated updates to gax_version, google_cloud_spanner_version, google_code_gson_version, and grpc_version following versions from https://mvnrepository.com/artifact/com.google.cloud/libraries-bom/26.20.0 (being indexed).

Attaching the effective pom generated with:

wget https://repo1.maven.org/maven2/com/google/cloud/libraries-bom/26.20.0/libraries-bom-26.20.0.pom

mvn help:effective-pom -f libraries-bom-26.20.0.pom

libraries-bom-26.20.0-effective-pom.txt

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #27725 (48084c6) into master (af533fe) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 48084c6 differs from pull request most recent head 8de4f3c. Consider uploading reports for the commit 8de4f3c to get more accurate results

@@            Coverage Diff             @@
##           master   #27725      +/-   ##
==========================================
- Coverage   70.90%   70.89%   -0.01%     
==========================================
  Files         860      860              
  Lines      104633   104633              
==========================================
- Hits        74187    74177      -10     
- Misses      28893    28902       +9     
- Partials     1553     1554       +1     
Flag Coverage Δ
python 80.00% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java.
R: @damccorm for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@bvolpato
Copy link
Contributor Author

Run Java PreCommit

@bvolpato
Copy link
Contributor Author

Run Java_PVR_Flink_Batch PreCommit

@bvolpato
Copy link
Contributor Author

Run Java_Pulsar_IO_Direct PreCommit

@bvolpato
Copy link
Contributor Author

Run SQL PreCommit

@bvolpato
Copy link
Contributor Author

Run SQL_Java17 PreCommit

@bvolpato
Copy link
Contributor Author

Run SQL_Java11 PreCommit

@bvolpato
Copy link
Contributor Author

Run Java PreCommit

@bvolpato
Copy link
Contributor Author

Run SQL PreCommit

@bvolpato
Copy link
Contributor Author

Run SQL_Java11 PreCommit

@bvolpato
Copy link
Contributor Author

Run SQL_Java17 PreCommit

@bvolpato
Copy link
Contributor Author

Investigating a few failures

@Abacn
Copy link
Contributor

Abacn commented Jul 28, 2023

I see, Could not resolve com.google.guava:guava:32.1.1-jre.

@bvolpato
Copy link
Contributor Author

Bumped version to be the same and giving it a try.

There's some weird handling of Guava that I am not familiar with. Both in terms of com.google.guava:listenablefuture and some handling to ignore any Android versions https://github.com/apache/beam/blob/master/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L1899-L1904

@bvolpato
Copy link
Contributor Author

bvolpato commented Jul 28, 2023

com.google.guava:guava:32.1.1-jre is valid, but it seems that it's being rejected by CI. Will need to take a more careful look

@bvolpato
Copy link
Contributor Author

Found the reason: https://github.com/google/guava/releases/tag/v32.1.0#user-content-overlap

Going to try the suggested fix

@bvolpato bvolpato force-pushed the update-libraries-bom-26.19.0 branch from d24ec7d to d34181c Compare July 28, 2023 13:41
@bvolpato
Copy link
Contributor Author

Run Java_PVR_Flink_Docker PreCommit

@bvolpato
Copy link
Contributor Author

Run GoPortable PreCommit

@bvolpato
Copy link
Contributor Author

Run Python_PVR_Flink PreCommit

@bvolpato bvolpato changed the title Update to libraries-bom 26.19.0 Update to libraries-bom 26.20.0 Jul 28, 2023
@bvolpato
Copy link
Contributor Author

@mutianf @suztomo Are you familiar with the changes that are happening on Bigtable?

Seems like it's hitting a real regression

16:15:38 > Task :sdks:java:extensions:sql:test
16:15:38 
16:15:38 org.apache.beam.sdk.extensions.sql.meta.provider.bigtable.BigtableTableFlatTest > testSegementedInsert FAILED
16:15:38     java.lang.AssertionError at BigtableTableFlatTest.java:164
16:15:38         Caused by: java.lang.AssertionError at MatcherAssert.java:18
16:15:38 
16:15:58 715 tests completed, 1 failed, 8 skipped

readTransformWithSegment (proxy to .withMaxBufferElementCount(2)) is apparently dropping records.

@mutianf
Copy link
Contributor

mutianf commented Jul 29, 2023

@bvolpato The test failure is caused from the emulator version bump. I'll look into it on Monday. I think we can revert the emulator version bump so the test can pass.

@bvolpato
Copy link
Contributor Author

@bvolpato The test failure is caused from the emulator version bump. I'll look into it on Monday. I think we can revert the emulator version bump so the test can pass.

@mutianf Thanks, doing it! The bump was to match libraries-bom, but perhaps this is the reason why a very old version was pinned.

@bvolpato
Copy link
Contributor Author

Run Spotless PreCommit

@bvolpato
Copy link
Contributor Author

Run CommunityMetrics PreCommit

@bvolpato
Copy link
Contributor Author

Run Spotless PreCommit

@bvolpato bvolpato force-pushed the update-libraries-bom-26.19.0 branch from 48084c6 to 6bbefdb Compare July 30, 2023 15:01
@bvolpato
Copy link
Contributor Author

Oof, this was more complicated than I expected.

Guava introduced some complications https://github.com/google/guava/releases#user-content-duplicate-ListenableFuture

It went as far as hanging/infinite looping Gradle in the classpath resolution when importing Truth, which is built against 32.0.1-android. Excluding it for now, and can bump + remove TODOs when Truth 1.1.6 is out (bump was done already google/truth@3f00bfe).

Also, google-cloud-bigtable-emulator could not be updated to 0.162.1 (to match libraries-bom) due to a regression in a testcase. Bigtable team is taking a look at this.

@Abacn Can you have a new look since this changed quite a bit since the last time you reviewed? Thanks!

@bvolpato bvolpato requested a review from Abacn July 30, 2023 15:42
Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@Abacn Abacn merged commit 97e5542 into apache:master Jul 31, 2023
18 checks passed
@bvolpato bvolpato deleted the update-libraries-bom-26.19.0 branch July 31, 2023 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants