-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to libraries-bom 26.20.0 #27725
Conversation
Codecov Report
@@ Coverage Diff @@
## master #27725 +/- ##
==========================================
- Coverage 70.90% 70.89% -0.01%
==========================================
Files 860 860
Lines 104633 104633
==========================================
- Hits 74187 74177 -10
- Misses 28893 28902 +9
- Partials 1553 1554 +1
Flags with carried forward coverage won't be shown. Click here to find out more. see 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Assigning reviewers. If you would like to opt out of this review, comment R: @kennknowles for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Run Java PreCommit |
Run Java_PVR_Flink_Batch PreCommit |
Run Java_Pulsar_IO_Direct PreCommit |
Run SQL PreCommit |
Run SQL_Java17 PreCommit |
Run SQL_Java11 PreCommit |
Run Java PreCommit |
Run SQL PreCommit |
Run SQL_Java11 PreCommit |
Run SQL_Java17 PreCommit |
Investigating a few failures |
I see, |
Bumped version to be the same and giving it a try. There's some weird handling of Guava that I am not familiar with. Both in terms of |
com.google.guava:guava:32.1.1-jre is valid, but it seems that it's being rejected by CI. Will need to take a more careful look |
Found the reason: https://github.com/google/guava/releases/tag/v32.1.0#user-content-overlap Going to try the suggested fix |
d24ec7d
to
d34181c
Compare
Run Java_PVR_Flink_Docker PreCommit |
Run GoPortable PreCommit |
Run Python_PVR_Flink PreCommit |
@mutianf @suztomo Are you familiar with the changes that are happening on Bigtable? Seems like it's hitting a real regression
|
@bvolpato The test failure is caused from the emulator version bump. I'll look into it on Monday. I think we can revert the emulator version bump so the test can pass. |
Run Spotless PreCommit |
Run CommunityMetrics PreCommit |
Run Spotless PreCommit |
48084c6
to
6bbefdb
Compare
Oof, this was more complicated than I expected. Guava introduced some complications https://github.com/google/guava/releases#user-content-duplicate-ListenableFuture It went as far as hanging/infinite looping Gradle in the classpath resolution when importing Truth, which is built against Also, @Abacn Can you have a new look since this changed quite a bit since the last time you reviewed? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix!
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
Outdated
Show resolved
Hide resolved
6bbefdb
to
8de4f3c
Compare
Update
google_cloud_platform_libraries_bom
to26.20.0
.Associated updates to
gax_version
,google_cloud_spanner_version
,google_code_gson_version
, andgrpc_version
following versions from https://mvnrepository.com/artifact/com.google.cloud/libraries-bom/26.20.0 (being indexed).Attaching the effective pom generated with:
libraries-bom-26.20.0-effective-pom.txt