Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update libraries bom version to 26.20.0 #27735

Closed
wants to merge 1 commit into from

Conversation

mutianf
Copy link
Contributor

@mutianf mutianf commented Jul 28, 2023

Update libraries bom version.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #27735 (aec6a69) into master (a4f2934) will increase coverage by 0.00%.
Report is 3 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #27735   +/-   ##
=======================================
  Coverage   70.89%   70.89%           
=======================================
  Files         860      860           
  Lines      104631   104635    +4     
=======================================
+ Hits        74176    74179    +3     
- Misses      28902    28903    +1     
  Partials     1553     1553           
Flag Coverage Δ
python 80.00% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @bvolpato for label java.
R: @damccorm for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@bvolpato
Copy link
Contributor

@mutianf Thanks!

I started a bump to 26.19.0 and having some issues due to a new Guava version #27725, working to handling the conflict for the listenablefuture deps.

Do we have anything specific that requires 26.20.0? Can pivot to that if needed

@mutianf
Copy link
Contributor Author

mutianf commented Jul 28, 2023

Hi @bvolpato, didn't realize you were already updating it to 26.19.0. Yes, we have a Bigtable fix in 26.20.0 that we wish to get in the beam 2.50.0.

@suztomo
Copy link
Contributor

suztomo commented Jul 28, 2023

Run Java Postcommit

@suztomo
Copy link
Contributor

suztomo commented Jul 28, 2023

It hit the Guava's recent Gradle metadata problem. https://github.com/google/guava/releases/tag/v32.1.0 "Still, read the release notes below if you use Gradle, since the fixed Gradle metadata in 32.1.1 may still require action on your part."

https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/27802/console

12:03:19 Execution failed for task ':sdks:java:extensions:sql:shell:analyzeClassesDependencies'.
12:03:19 > Could not resolve all files for configuration ':sdks:java:extensions:sql:shell:permitUnusedDeclared'.
12:03:19    > Could not resolve com.google.guava:guava:32.1.1-jre.
12:03:19      Required by:
12:03:19          project :sdks:java:extensions:sql:shell > project :sdks:java:extensions:sql:jdbc > project :sdks:java:extensions:sql > com.google.cloud:libraries-bom:26.20.0
12:03:19          project :sdks:java:extensions:sql:shell > project :sdks:java:extensions:sql:jdbc > project :sdks:java:extensions:sql > com.google.api.grpc:proto-google-cloud-bigtable-v2:2.25.1
12:03:19          project :sdks:java:extensions:sql:shell > project :sdks:java:extensions:sql:jdbc > project :sdks:java:extensions:sql > com.google.cloud:google-cloud-pubsublite:1.12.12
12:03:19          project :sdks:java:extensions:sql:shell > project :sdks:java:extensions:sql:jdbc > project :sdks:java:extensions:sql > com.google.api.grpc:proto-google-cloud-pubsublite-v1:1.12.12
12:03:19          project :sdks:java:extensions:sql:shell > project :sdks:java:extensions:sql:jdbc > project :sdks:java:extensions:sql > project :sdks:java:io:google-cloud-platform > com.google.api:gax-grpc:2.31.1
12:03:19          project :sdks:java:extensions:sql:shell > project :sdks:java:extensions:sql:jdbc > project :sdks:java:extensions:sql > project :sdks:java:io:google-cloud-platform > com.google.api:gax:2.31.1
12:03:19          project :sdks:java:extensions:sql:shell > project :sdks:java:extensions:sql:jdbc > project :sdks:java:extensions:sql > project :sdks:java:io:google-cloud-platform > com.google.api:gax-httpjson:2.31.1
12:03:19          project :sdks:java:extensions:sql:shell > project :sdks:java:extensions:sql:jdbc > project :sdks:java:extensions:sql > project :sdks:java:io:google-cloud-platform > com.google.api:api-common:2.14.1
12:03:19          project :sdks:java:extensions:sql:shell > project :sdks:java:extensions:sql:jdbc > project :sdks:java:extensions:sql > project :sdks:java:io:google-cloud-platform > com.google.cloud:google-cloud-bigquerystorage:2.41.0
12:03:19          project :sdks:java:extensions:sql:shell > project :sdks:java:extensions:sql:jdbc > project :sdks:java:extensions:sql > project :sdks:java:io:google-cloud-platform > com.google.cloud:google-cloud-bigtable:2.25.1
12:03:19          project :sdks:java:extensions:sql:shell > project :sdks:java:extensions:sql:jdbc > project :sdks:java:extensions:sql > project :sdks:java:io:google-cloud-platform > com.google.cloud:google-cloud-core:2.21.1
12:03:19          project :sdks:java:extensions:sql:shell > project :sdks:java:extensions:sql:jdbc > project :sdks:java:extensions:sql > project :sdks:java:io:google-cloud-platform > com.google.cloud:google-cloud-core-grpc:2.21.1
12:03:19          project :sdks:java:extensions:sql:shell > project :sdks:java:extensions:sql:jdbc > project :sdks:java:extensions:sql > project :sdks:java:io:google-cloud-platform > com.google.cloud:google-cloud-firestore:3.13.7
12:03:19          project :sdks:java:extensions:sql:shell > project :sdks:java:extensions:sql:jdbc > project :sdks:java:extensions:sql > project :sdks:java:io:google-cloud-platform > com.google.cloud:google-cloud-pubsub:1.124.0
12:03:19          project :sdks:java:extensions:sql:shell > project :sdks:java:extensions:sql:jdbc > project :sdks:java:extensions:sql > project :sdks:java:io:google-cloud-platform > com.google.cloud:google-cloud-spanner:6.44.0
12:03:19          project :sdks:java:extensions:sql:shell > project :sdks:java:extensions:sql:jdbc > project :sdks:java:extensions:sql > project :sdks:java:io:google-cloud-platform > com.google.api.grpc:grpc-google-cloud-pubsub-v1:1.106.0
12:03:19          project :sdks:java:extensions:sql:shell > project :sdks:java:extensions:sql:jdbc > project :sdks:java:extensions:sql > project :sdks:java:io:google-cloud-platform > com.google.api.grpc:grpc-google-cloud-pubsublite-v1:1.12.12
12:03:19          project :sdks:java:extensions:sql:shell > project :sdks:java:extensions:sql:jdbc > project :sdks:java:extensions:sql > project :sdks:java:io:google-cloud-platform > com.google.api.grpc:proto-google-cloud-bigquerystorage-v1:2.41.0
12:03:19          project :sdks:java:extensions:sql:shell > project :sdks:java:extensions:sql:jdbc > project :sdks:java:extensions:sql > project :sdks:java:io:google-cloud-platform > com.google.api.grpc:proto-google-cloud-firestore-v1:3.13.7
12:03:19          project :sdks:java:extensions:sql:shell > project :sdks:java:extensions:sql:jdbc > project :sdks:java:extensions:sql > project :sdks:java:io:google-cloud-platform > com.google.api.grpc:proto-google-cloud-pubsub-v1:1.106.0
12:03:19          project :sdks:java:extensions:sql:shell > project :sdks:java:extensions:sql:jdbc > project :sdks:java:extensions:sql > project :sdks:java:io:google-cloud-platform > com.google.api.grpc:proto-google-cloud-spanner-admin-database-v1:6.44.0
12:03:19          project :sdks:java:extensions:sql:shell > project :sdks:java:extensions:sql:jdbc > project :sdks:java:extensions:sql > project :sdks:java:io:google-cloud-platform > com.google.api.grpc:proto-google-cloud-spanner-v1:6.44.0
12:03:19          project :sdks:java:extensions:sql:shell > project :sdks:java:extensions:sql:jdbc > project :sdks:java:extensions:sql > com.google.cloud:libraries-bom:26.20.0 > com.google.api.grpc:grpc-google-cloud-storage-v2:2.25.0-alpha
12:03:19          project :sdks:java:extensions:sql:shell > project :sdks:java:extensions:sql:jdbc > project :sdks:java:extensions:sql > com.google.cloud:libraries-bom:26.20.0 > com.google.cloud:proto-google-cloud-firestore-bundle-v1:3.13.7
12:03:19          project :sdks:java:extensions:sql:shell > project :sdks:java:extensions:sql:jdbc > project :sdks:java:extensions:sql > com.google.cloud:libraries-bom:26.20.0 > com.google.api.grpc:proto-google-cloud-storage-v2:2.25.0-alpha
12:03:19       > Module 'com.google.guava:guava' has been rejected:
12:03:19            Cannot select module with conflict on capability 'com.google.guava:listenablefuture:1.0' also provided by [com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava(runtime)]
12:03:19    > Could not resolve com.google.guava:guava:32.0.1-jre.
12:03:19      Required by:
12:03:19          project :sdks:java:extensions:sql:shell > project :sdks:java:extensions:sql:jdbc > project :sdks:java:extensions:sql > project :sdks:java:io:google-cloud-platform
12:03:19       > Module 'com.google.guava:guava' has been rejected:
12:03:19            Cannot select module with conflict on capability 'com.google.guava:listenablefuture:1.0' also provided by [com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava(runtime)]
12:03:19    > Could not resolve com.google.guava:guava:31.1-jre.
12:03:19      Required by:
12:03:19          project :sdks:java:extensions:sql:shell > project :sdks:java:extensions:sql:jdbc > project :sdks:java:extensions:sql > com.google.protobuf:protobuf-java-util:3.23.2
12:03:19          project :sdks:java:extensions:sql:shell > project :sdks:java:extensions:sql:jdbc > project :sdks:java:extensions:sql > project :sdks:java:extensions:google-cloud-platform-core > com.google.api-client:google-api-client:2.2.0
12:03:19          project :sdks:java:extensions:sql:shell > project :sdks:java:extensions:sql:jdbc > project :sdks:java:extensions:sql > project :sdks:java:io:google-cloud-platform > com.google.cloud.datastore:datastore-v1-proto-client:2.15.0
12:03:19          project :sdks:java:extensions:sql:shell > project :sdks:java:extensions:sql:jdbc > project :sdks:java:extensions:sql > project :sdks:java:io:google-cloud-platform > io.grpc:grpc-alts:1.56.1
12:03:19          project :sdks:java:extensions:sql:shell > project :sdks:java:extensions:sql:jdbc > project :sdks:java:extensions:sql > com.google.cloud:google-cloud-pubsublite:1.12.12 > io.grpc:grpc-googleapis:1.56.1
12:03:19          project :sdks:java:extensions:sql:shell > project :sdks:java:extensions:sql:jdbc > project :sdks:java:extensions:sql > com.google.cloud:google-cloud-pubsublite:1.12.12 > io.grpc:grpc-services:1.56.1
12:03:19       > Module 'com.google.guava:guava' has been rejected:
12:03:19            Cannot select module with conflict on capability 'com.google.guava:listenablefuture:1.0' also 

@bvolpato
Copy link
Contributor

bvolpato commented Jul 28, 2023

Yes, I am trying to handle this in the other PR #27725. Just submitted something to completely exclude listenablefuture and will see how it goes.

It's up to you -- I can either pivot to 26.20.0 (I was using 26.19.0 because it's still latest according to https://cloud.google.com/java/docs/bom), or you can address the Guava bump here as well and I can close mine.

@mutianf
Copy link
Contributor Author

mutianf commented Jul 28, 2023

I believe 26.20.0 was cut yesterday so it hasn't showed up in maven central or public doc page yet. https://mvnrepository.com/artifact/com.google.cloud/libraries-bom. I also realized that I missed a few dependency updates in this PR. Can you pick up 26.20.0 in your PR? I'll close this one. Thank you! @bvolpato

@mutianf mutianf closed this Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants