GH-41725: [Python] CMake: ignore Parquet encryption option if Parquet itself is not enabled (fix Java integration build) #41776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sabled (same as base parquwet) - fix Java integration build
jorisvandenbossche
requested review from
assignUser,
kou and
raulcd
as code owners
|
|
jorisvandenbossche
changed the title
|
This seems to work, the Java C Data Integration build is working again (and showing the cmake warning; I could fix that warning but not entirely sure I should just disable parquet encryption by default in |
This reverts commit abcdf76.
github-actions
bot
added
awaiting merge
|
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 9bd0ddb. There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
vibhatha
pushed a commit
to vibhatha/arrow
that referenced
this pull request
May 25, 2024
…arquet itself is not enabled (fix Java integration build) (apache#41776) ### Rationale for this change Because of refactoring in apache#41480, explicitly enabling `PYARROW_WITH_PARQUET_ENCRYPTION` without enabling `PYARROW_WITH_PARQUET` (and without Arrow C++ being built with Parquet support) now raises an error, while before we checked in `setup.py` that both were enabled for enabling encryption support. This patch mimics that logic in CMakeLists.txt with a warning added. ### What changes are included in this PR? When PyArrow with Parquet Encryption is enabled but PyArrow with Parquet itself is not, ignore the encryption setting, but warn about it. ### Are these changes tested? Yes * GitHub Issue: apache#41725 Authored-by: Joris Van den Bossche <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Because of refactoring in #41480, explicitly enabling
PYARROW_WITH_PARQUET_ENCRYPTIONwithout enablingPYARROW_WITH_PARQUET(and without Arrow C++ being built with Parquet support) now raises an error, while before we checked insetup.pythat both were enabled for enabling encryption support. This patch mimics that logic in CMakeLists.txt with a warning added.What changes are included in this PR?
When PyArrow with Parquet Encryption is enabled but PyArrow with Parquet itself is not, ignore the encryption setting, but warn about it.
Are these changes tested?
Yes