Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up host CLI #536

Merged
merged 7 commits into from
Sep 18, 2024
Merged

chore: clean up host CLI #536

merged 7 commits into from
Sep 18, 2024

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Sep 18, 2024

Overview

Cleans up the host CLI validation by using the native features of the clap::arg proc macro over a custom validation function. Also adjusts some of the flag docs to be a bit more helpful.

and, colors, because it's kind of cool 🎨

Screenshot 2024-09-18 at 3 19 30 AM

@clabby clabby self-assigned this Sep 18, 2024
@clabby clabby added A-host Area: host binary K-feature Kind: feature labels Sep 18, 2024
Copy link
Collaborator Author

clabby commented Sep 18, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @clabby and the rest of your teammates on Graphite Graphite

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.2%. Comparing base (22a3c62) to head (0886c8f).
Report is 1 commits behind head on cl/preimage-error.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clabby clabby changed the title chore: clean up host CLI validation chore: clean up host CLI Sep 18, 2024
Copy link
Collaborator

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - though Q on the change in default tracing levels.

bin/host/src/cli/tracing_util.rs Show resolved Hide resolved
@clabby clabby merged commit cc41146 into cl/preimage-error Sep 18, 2024
17 checks passed
@clabby clabby mentioned this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-host Area: host binary K-feature Kind: feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants