Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(preimage): Improve error differentiation in preimage servers #535

Merged
merged 4 commits into from
Sep 18, 2024

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Sep 18, 2024

Overview

Improves the differentiation of errors in the preimage server routes. This allows for us to throw on non-pipe related errors, rather than silently fail and assume that the exit is related to a broken pipe.

Also fixes an edge case where if the HintReaderServer receives bad UTF-8, it will block forever.

@clabby clabby self-assigned this Sep 18, 2024
@clabby clabby added K-chore Kind: chore A-host Area: host binary labels Sep 18, 2024
Copy link
Collaborator Author

clabby commented Sep 18, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @clabby and the rest of your teammates on Graphite Graphite

@clabby clabby requested a review from refcell September 18, 2024 03:47
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 98.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.1%. Comparing base (83becd6) to head (22a3c62).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/preimage/src/hint.rs 98.7% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clabby clabby changed the title chore(preimage): Improve error differentiation in preimage servers fix(preimage): Improve error differentiation in preimage servers Sep 18, 2024
@clabby clabby mentioned this pull request Sep 18, 2024
@refcell refcell added this pull request to the merge queue Sep 18, 2024
Merged via the queue into main with commit 5c2d272 Sep 18, 2024
17 checks passed
This was referenced Sep 18, 2024
This was referenced Sep 27, 2024
This was referenced Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-host Area: host binary K-chore Kind: chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants