Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade hello-vulkan's kotlin to match the other samples. #1027

Merged
merged 4 commits into from
May 7, 2024
Merged

Downgrade hello-vulkan's kotlin to match the other samples. #1027

merged 4 commits into from
May 7, 2024

Commits on May 7, 2024

  1. Migrate to settings.gradle repositories. 

    Preferred for newer projects, all the others do it, and gradle complains
if we mix and match in the parent project.
    @DanAlbert
    DanAlbert committed May 7, 2024
    Configuration menu
    Copy the full SHA
    65a8f35 View commit details
    Browse the repository at this point in the history

  2. Modernize build.gradle plugin use.

    @DanAlbert
    DanAlbert committed May 7, 2024
    Configuration menu
    Copy the full SHA
    e7c47cf View commit details
    Browse the repository at this point in the history

  3. Remove unused dependency.

    @DanAlbert
    DanAlbert committed May 7, 2024
    Configuration menu
    Copy the full SHA
    c66a3e6 View commit details
    Browse the repository at this point in the history

  4. Downgrade Kotlin in hello-vulkan to match others. 

    The Kotlin use here is trivial (it might actually be better to make all
the NativeActivity-esque samples Java, since it's fewer dependencies and
less stuff in the APK, which I expect games typically want). I'll
upgrade the whole repo to something actually modern once I can do it as
a batch as opposed to repo by repo. I need all the kotlin versions
matching before I can do that though, and everything else is on 1.7.21.
    @DanAlbert
    DanAlbert committed May 7, 2024
    Configuration menu
    Copy the full SHA
    654e5c4 View commit details
    Browse the repository at this point in the history