Downgrade hello-vulkan's kotlin to match the other samples. #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfgoog
approved these changes
May 7, 2024
Preferred for newer projects, all the others do it, and gradle complains if we mix and match in the parent project.
The Kotlin use here is trivial (it might actually be better to make all the NativeActivity-esque samples Java, since it's fewer dependencies and less stuff in the APK, which I expect games typically want). I'll upgrade the whole repo to something actually modern once I can do it as a batch as opposed to repo by repo. I need all the kotlin versions matching before I can do that though, and everything else is on 1.7.21.
DanAlbert
force-pushed
the
fix-vulkan-kotlin
branch
from
980d225
to
654e5c4
Compare
DanAlbert
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combining all the samples into one project means they have to all use the same Kotlin plugin version, which is 1.7.21 for all the others.