Support for v2 of tdd driver #491
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check for version attribute in the tdd driver(only exists in v2) if found, load the new plugin if version attr not found, the previous version of the plugin is loaded Signed-off-by: Cristina Suteu <[email protected]>
nunojsa
reviewed
May 23, 2024
| struct osc_plugin_context plugin_ctx; | ||
| /* iio */ | ||
| struct iio_context *ctx; | ||
| /* misc */ | ||
| /* misc */ |
There was a problem hiding this comment.
all the above look unrelated changes...
|
|
||
| if(!iio_device_find_attr(dev, "version")) { | ||
| if (osc_load_glade_file(priv->builder, "cf_axi_tdd") < 0) | ||
| goto context_destroy; |
There was a problem hiding this comment.
The indentation looks wrong... Please don't mix styles in the same file/plugin. This one is likely (as I did it :)) using tabs (8 spaces) so please use the same style. It also looks like some widgets have the same attrs (like burst_count and frame_length_ms) so make sure to not duplicate code if not needed.
Also, since for v2 you're initializing all the widgets in cf_axi_tdd_v2_widgets_init(), I would consider in having a precursor patch adding a similar function to the legacy plugin so things are consistent.
|
|
||
| reload_btn = GTK_BUTTON(gtk_builder_get_object(priv->builder, "settings_reload")); | ||
| g_signal_connect(G_OBJECT(reload_btn), "clicked", G_CALLBACK(reload_settings), | ||
| priv); |
There was a problem hiding this comment.
this also looks to be duplicated code...
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
A new version of the tdd driver will be released soon. This ensures support for both versions of the driver. This is done by checking for the version attribute, which only exists in v2 of the driver. If said attribute is found, osc will load the newly added glade file, with widgets corresponding to the new attribute. If the version attribute is not found, osc will load the old plugin.
Note: this is still under development and will be updated if the requirements/ functionality would change.
PR Type
PR Checklist