Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Staging/fix dts iio tdd #2511

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Staging/fix dts iio tdd #2511

merged 2 commits into from
Jun 17, 2024

Conversation

eliza-balas
Copy link
Contributor

@eliza-balas eliza-balas commented Jun 13, 2024 •
edited
Loading

PR Description

  • The zcu102/ad9081 device tree should export only channel 0 and channel 1 for TDD iio device (for each axi data offload)
  • The Stingray device tree should export 6 tdd channels. The zcu102/ad9081 iio TDD node is overwritten to reflect all 6 channels.
  • The new TDD driver causes the ad9081 plugin in iio oscilloscope to crash. There is an open PR at Support for v2 of tdd driver iio-oscilloscope#491

PR Type

  • Bug fix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

  • I have conducted a self-review of my own code changes
  • I have tested the changes on the relevant hardware
  • I have updated the documentation outside this repo accordingly (if there is the case)

@eliza-balas
arch: arm64: boot: dts: Remove iio channel 2 for TDD in zcu102/ad9081 dt
7b98df1 
- Add label for the iio-axi-tdd-0 device.
- Export only channel 0 and channel 1 for TDD iio device.

axi_tdd_0/tdd_channel_0 -> axi_data_offload_tx/sync_ext
axi_tdd_0/tdd_channel_1 -> axi_data_offload_rx/sync_ext

Signed-off-by: Eliza Balas <[email protected]>
@eliza-balas
arch: arm64: boot: dts: Overwrite the iio TDD node for Stingray dt
d02cfb2 
In the Stingray project, 6 tdd channels are used.

The first 2 channels are connected to
the sync_ext pins of the data offload cores.

axi_tdd_0/tdd_channel_0 -> axi_data_offload_tx/sync_ext
axi_tdd_0/tdd_channel_1 -> axi_data_offload_rx/sync_ext

The remaining 4 channels are mapped as following:

axi_tdd_0/tdd_channel_2 -> tdd_enabled
axi_tdd_0/tdd_channel_3 -> tdd_rx_mxfe_en
axi_tdd_0/tdd_channel_4 -> tdd_tx_mxfe_en
axi_tdd_0/tdd_channel_5 -> tdd_tx_stingray_en

While the TDD core is enabled, tdd_channel_2
should always output logic '1', for the
tdd_enabled signal.

Signed-off-by: Eliza Balas <[email protected]>
@eliza-balas eliza-balas merged commit 9b2de6e into main Jun 17, 2024
13 checks passed
@eliza-balas eliza-balas deleted the staging/fix-dts-iio-tdd branch June 17, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunojsa nunojsa nunojsa approved these changes

@mhennerich mhennerich Awaiting requested review from mhennerich mhennerich is a code owner

@dbogdan dbogdan Awaiting requested review from dbogdan dbogdan is a code owner

@btogorean btogorean Awaiting requested review from btogorean btogorean is a code owner

@chegbeli chegbeli Awaiting requested review from chegbeli chegbeli is a code owner

@buha buha Awaiting requested review from buha buha is a code owner

@amiclaus amiclaus Awaiting requested review from amiclaus amiclaus is a code owner

@rbolboac rbolboac Awaiting requested review from rbolboac rbolboac is a code owner

@danmois danmois Awaiting requested review from danmois danmois is a code owner

@CiprianRegus CiprianRegus Awaiting requested review from CiprianRegus CiprianRegus is a code owner

@machschmitt machschmitt Awaiting requested review from machschmitt machschmitt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eliza-balas @nunojsa