Fix attachment metadata styling issue #3501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinJJones
force-pushed
the
fix-attachment-metadata-styling-issue
branch
from
8b96450
to
5334a09
Compare
Fixes a styling issue where long strings of text for external links do not wrap onto a new line, causing them to overlap with some other elements on the page.
MartinJJones
force-pushed
the
fix-attachment-metadata-styling-issue
branch
from
5334a09
to
5e8238d
Compare
|
Github issue created to review the attachment component further in the future, includes further info on IE11 - #3503 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes a styling issue where long strings of text for external links do not wrap onto a new line.
The approach used to fix the issue is the same as that used in the Design System - https://github.com/alphagov/govuk-frontend/blob/49a3eb389eec89e004873ddfeb8c1f9aa1d572e4/packages/govuk-frontend/src/govuk/components/summary-list/_index.scss#L64-L68
Why
The long string of text was not contained and overlapped with other elements on the page.
Further info
Tested in the browsers below using BrowserStack:
The issue still exists in IE11, but it is worth noting that this issue existed before the recent change to use the attachment component from the gem.
I will create a separate issue for IE11, so this can be looked into separately.
Visual Changes
Before
Before - If the 1st link does not contain a hyphen
After