Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review attachment component with external links #3503

Open
MartinJJones opened this issue Jul 18, 2023 · 2 comments
Open

Review attachment component with external links #3503

MartinJJones opened this issue Jul 18, 2023 · 2 comments
Labels
accessibility Accessibility issues identified design Design inconsistencies and quirks IE11 Internet Explorer

Comments

@MartinJJones
Copy link
Contributor

MartinJJones commented Jul 18, 2023

What

There appears to be a couple of issues with the attachment component with external links that are worth looking into further:

  • In IE11, long URL strings are not contained and may overlap with other elements on the page as shown in the screenshot below
  • The metadata text size is not consistent with other metadata component styles, here it is 19px, should it be 16px?
  • The URL's visual don't look great on the page
  • How well do they work with screenreaders?

Screenshot showing the issue in IE11

before-text-no-hyphen

Further info

@MartinJJones MartinJJones added accessibility Accessibility issues identified design Design inconsistencies and quirks IE11 labels Jul 18, 2023
@nnagewad
Copy link

nnagewad commented Jun 7, 2024

@MartinJJones is this still an issue?

@MartinJJones
Copy link
Contributor Author

@MartinJJones is this still an issue?

This does still appear to be an issue in IE11, I was able to reproduce this in BrowserStack by testing in IE11 and modifying an attachment url to include a long string with no hyphens to break the text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Accessibility issues identified design Design inconsistencies and quirks IE11 Internet Explorer
Projects
None yet
Development

No branches or pull requests

2 participants