Fix Bash completions #1721
Fix Bash completions #1721
Conversation
pdietl
force-pushed
the
pdietl/fix_bash_completions
branch
from
ae6d09e
to
7e6e412
Compare
The previous completion script was including extra completions that were not actually commands. This commit also moves the completion file and renames it such that on Ubuntu one can simple download the release zip, unpack it, cd into the unpacked directory, and run `cp -r bin share /usr/local` to install with bash-completions in the proper place to get automatically sourced
pdietl
force-pushed
the
pdietl/fix_bash_completions
branch
from
7e6e412
to
37f82d5
Compare
| @@ -66,7 +66,9 @@ jobs: | |||
|
|
|||
| - name: Package binaries | |||
| if: (github.event_name == 'release') | |||
| run: zip alr-bin-linux.zip bin/alr LICENSE.txt | |||
| run: | | |||
| echo 'sudo cp -r bin share /usr/local/' > INSTALL.md | |||
There was a problem hiding this comment.
I'd rather have a proper INSTALL.md file a bit more fleshed out, where this command is not just given but also explained. Some people may prefer to use another prefix not requiring sudo.
There was a problem hiding this comment.
Should I make this Linux-specific or even distro specific? I believe that where to put Bash completion files is a bit distro-dependent.
There was a problem hiding this comment.
Can this be found automatically? Otherwise I don't think we want to manually maintain such a thing. We can explain in the INSTALL.md file that the given structure is for Debian and should be tweaked if needed. Also yes, I think the INSTALL.md should make clear this is only for Unix-like, and that there's a Windows installer.
Fix Bash completions
The previous completion script was including extra completions that were not actually commands.
This commit also moves the completion file and renames it such that on Ubuntu one can simple download the release zip, unpack it, cd into the unpacked directory, and run
cp -r bin share /usr/local/to install with bash-completions in the proper place to get automatically sourced