Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature : AlephDNS (2nd attempt) #55

Merged
merged 25 commits into from
Nov 21, 2023
Merged

Feature : AlephDNS (2nd attempt) #55

merged 25 commits into from
Nov 21, 2023

Conversation

hoh
Copy link
Member

@hoh hoh commented Aug 28, 2023

The previous Pull Request #47 failed to match our standards, broke PEP8 and code quality and caused issues for further development.

This is a new Pull Request aiming at getting these changes merged.

  • Feature : AlephDNS add instances support
    add ipfs support
    add program support

src/aleph/sdk/conf.py Show resolved Hide resolved
src/aleph/sdk/conf.py Show resolved Hide resolved
src/aleph/sdk/domain.py Outdated Show resolved Hide resolved
@MHHukiewitz
Copy link
Member

@hoh @aliel who is responsible for pushing this forward currently?

@MHHukiewitz MHHukiewitz reopened this Nov 13, 2023
@github-actions github-actions bot added the RED This PR is complex and may require more time to review. label Nov 13, 2023
Copy link

  • New dependencies added (aiodns).
  • New files added (src/aleph/sdk/domain.py and tests/unit/test_domains.py).
  • Multiple existing files modified (setup.cfg, src/aleph/sdk/conf.py, src/aleph/sdk/exceptions.py).

The complexity of the changes necessitates a thorough review to understand the added features and ensure that they align with the project's architecture and best practices. Additionally, the impact on existing functionality may require careful consideration and testing. This PR should be reviewed by an experienced developer who is familiar with the project and has knowledge of the technologies involved (Python, aiodns).

@MHHukiewitz MHHukiewitz requested review from aliel and removed request for odesenfans November 21, 2023 09:18
@MHHukiewitz MHHukiewitz merged commit 5e47d96 into main Nov 21, 2023
11 checks passed
@MHHukiewitz MHHukiewitz deleted the alephdns branch November 21, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RED This PR is complex and may require more time to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants