Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: add custom domain support #167

Merged
merged 13 commits into from
Nov 29, 2023
Merged

Feature: add custom domain support #167

merged 13 commits into from
Nov 29, 2023

Conversation

aliel
Copy link
Member

@aliel aliel commented Sep 29, 2023 •
edited
Loading

@hoh
to review/merge after =>
aleph-im/aleph-sdk-python#55

@aliel aliel changed the title add custom domain support Feature: add custom domain support Sep 29, 2023
@aliel aliel force-pushed the aliel-add-custom-domains-support branch 2 times, most recently from 9b77354 to 1fe4a09 Compare October 12, 2023 09:39
@aliel aliel requested a review from hoh October 12, 2023 10:15
@MHHukiewitz MHHukiewitz force-pushed the aliel-add-custom-domains-support branch from efc265a to 30e19e8 Compare November 21, 2023 11:05
@MHHukiewitz MHHukiewitz reopened this Nov 21, 2023
@MHHukiewitz MHHukiewitz added the BLACK This PR has critical implications and must be reviewed by a senior engineer. label Nov 21, 2023
@MHHukiewitz
Copy link
Member

Assigned BLACK, as it exceeds Llama context size

@aliel aliel force-pushed the aliel-add-custom-domains-support branch from ee808e8 to ad84357 Compare November 22, 2023 10:11
@aleph-im aleph-im deleted a comment from github-actions bot Nov 22, 2023
@MHHukiewitz
Copy link
Member

CI/CD fails because of an oversight on my side... There's two different ways messages are being returned from the API.

  1. /messages.json endpoint formats time as a float
  2. /messages/<item_hash> formats them as ISO strings.

The recent merge of aleph-im/aleph-sdk-python#81 now pulls messages from endpoint 2) and therefore validation of the time field fails.

This PR aleph-im/aleph-message#40 should fix it.

MHHukiewitz
MHHukiewitz requested changes Nov 22, 2023
View reviewed changes
Copy link
Member

@MHHukiewitz MHHukiewitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only necessary change is to replace @coro annotations by using app = AsyncTyper() from aleph_client.utils

src/aleph_client/commands/domain.py Outdated Show resolved Hide resolved
src/aleph_client/commands/domain.py Show resolved Hide resolved
src/aleph_client/commands/domain.py Outdated Show resolved Hide resolved
@MHHukiewitz MHHukiewitz force-pushed the aliel-add-custom-domains-support branch from 7539a33 to d2a5c25 Compare November 29, 2023 15:13
MHHukiewitz
MHHukiewitz reviewed Nov 29, 2023
View reviewed changes
setup.cfg Outdated Show resolved Hide resolved
MHHukiewitz
MHHukiewitz approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@MHHukiewitz MHHukiewitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MHHukiewitz MHHukiewitz merged commit f185fd2 into master Nov 29, 2023
6 checks passed
@MHHukiewitz MHHukiewitz deleted the aliel-add-custom-domains-support branch November 29, 2023 15:23
@MHHukiewitz MHHukiewitz mentioned this pull request Dec 13, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MHHukiewitz MHHukiewitz MHHukiewitz approved these changes

@hoh hoh Awaiting requested review from hoh

Assignees
No one assigned
Labels
BLACK This PR has critical implications and must be reviewed by a senior engineer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aliel @MHHukiewitz