Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source-snapchat-marketing(fix): re-implement advanced-auth in spec #48375

Merged
merged 5 commits into from
Nov 7, 2024

Conversation

ChristoGrab
Copy link
Contributor

@ChristoGrab ChristoGrab commented Nov 5, 2024

What

The advanced_auth configuration was accidentally removed from Snapchat Marketing in version 1.3.0, when we migrated the connector to manifest-only format. This has led to the removal of the automated auth flow in Cloud. This PR is a patch that reimplements the advanced_auth config in the spec.

How

  • Adds the previously extant advanced_auth configuration to the spec
  • Tested by pinning my sandbox connection to a pre-release version and was able to navigate the auth flow successfully.

Screenshot 2024-11-06 at 11 54 29 AM

  • Also pinned connector to the last working version 1.2.12, created a connection, synced, and verified that the next sync worked after updating to the pre-release version:
Screenshot 2024-11-06 at 1 01 28 PM

Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2024 6:42pm

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Nov 5, 2024
@ChristoGrab ChristoGrab marked this pull request as ready for review November 6, 2024 21:41
@octavia-squidington-iv octavia-squidington-iv requested a review from a team November 6, 2024 21:42
Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @ChristoGrab :shipit:

@ChristoGrab ChristoGrab merged commit 3cdf07e into master Nov 7, 2024
44 checks passed
@ChristoGrab ChristoGrab deleted the christo/snapchat-oauth-fix branch November 7, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/snapchat-marketing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants