fix (airbyte-ci): include advanced_auth in spec migration #48404
+23
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
/format-fix
|
maxi297
reviewed
Nov 7, 2024
|
@maxi297 Here's some local results from running the migration on Facebook Pages, which uses advanced_auth: Exhibit A: Current behavior
Exhibit B: Fixed behavior
|
maxi297
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
With the manual test, I'm fine with this change. Thanks @ChristoGrab !
…hub.com/airbytehq/airbyte into christo/manifest-migration-adv-auth-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Following up on 48375, we caught that advanced_auth config was not being migrated to the inlined spec in manifest-only migrations. Whoops 😬
How