Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(source-amazon-ads): set is_resumable only for Fullrefresh streams #48343

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
+9 −7
Open

fix(source-amazon-ads): set is_resumable only for Fullrefresh streams #48343

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
69adfd3
Amazon Ads: ref is_resumable
artem1205 Nov 5, 2024
7d2192a
Amazon Ads: update docs
artem1205 Nov 5, 2024
eb3392e
Amazon Ads: fmt
artem1205 Nov 5, 2024
c9b1019
Merge branch 'master' into artem1205/source-amazon-ads-fix-state
artem1205 Nov 5, 2024
bf81f22
Amazon Ads: pdate unit tests
artem1205 Nov 6, 2024
13e5d9f
Amazon Ads: fmt
artem1205 Nov 6, 2024
3bb6514
Amazon Ads: fmt
artem1205 Nov 6, 2024
b8a1d98
Amazon Ads: ref
artem1205 Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-amazon-ads/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ data:
connectorSubtype: api
connectorType: source
definitionId: c6b0a29e-1da9-4512-9002-7bfd0cba2246
dockerImageTag: 6.1.2
dockerImageTag: 6.1.3
dockerRepository: airbyte/source-amazon-ads
documentationUrl: https://docs.airbyte.com/integrations/sources/amazon-ads
githubIssueLabel: source-amazon-ads
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-amazon-ads/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ requires = [ "poetry-core>=1.0.0",]
build-backend = "poetry.core.masonry.api"

[tool.poetry]
version = "6.1.2"
version = "6.1.3"
name = "source-amazon-ads"
description = "Source implementation for Amazon Ads."
authors = [ "Airbyte <[email protected]>",]
Expand Down
3 changes: 1 addition & 2 deletions airbyte-integrations/connectors/source-amazon-ads/source_amazon_ads/streams/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,6 @@ class BasicAmazonAdsStream(Stream, ABC):
Base class for all Amazon Ads streams.
"""

is_resumable = False

def __init__(self, config: Mapping[str, Any], profiles: List[dict[str, Any]] = None):
self._profiles = profiles or []
self._client_id = config["client_id"]
Expand Down Expand Up @@ -183,6 +181,7 @@ class SubProfilesStream(AmazonAdsStream):
Stream for getting resources with pagination support and getting resources based on list of profiles set by source.
"""

is_resumable = False
page_size = 100

def __init__(self, *args, **kwargs):
Expand Down
3 changes: 0 additions & 3 deletions ...s/connectors/source-amazon-ads/source_amazon_ads/streams/report_streams/report_streams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,9 +307,6 @@ def state(self):
def state(self, value):
self._state = deepcopy(value)

def get_updated_state(self, current_stream_state: Dict[str, Any], latest_data: Mapping[str, Any]) -> Mapping[str, Any]:
return self._state

def _update_state(self, profile: dict[str, Any], report_date: str):
report_date = pendulum.from_format(report_date, self.REPORT_DATE_FORMAT).date()
look_back_date = pendulum.today(tz=profile["timezone"]).date().subtract(days=self._look_back_window - 1)
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/sources/amazon-ads.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,7 @@ Information about expected report generation waiting time can be found [here](ht

| Version | Date | Pull Request | Subject |
|:--------|:-----------|:---------------------------------------------------------|:----------------------------------------------------------------------------------------------------------------|
| 6.1.3 | 2024-11-05 | [48343](https://github.com/airbytehq/airbyte/pull/48343) | Set is_resumable only for FullRefresh streams |
| 6.1.2 | 2024-11-04 | [48138](https://github.com/airbytehq/airbyte/pull/48138) | Add error message for TooManyRequests exception |
| 6.1.1 | 2024-11-04 | [48128](https://github.com/airbytehq/airbyte/pull/48128) | Fix date parse in report streams |
| 6.1.0 | 2024-11-01 | [47940](https://github.com/airbytehq/airbyte/pull/47940) | Bump CDK to ^5 |
Expand Down
Loading