Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(source-amazon-ads): set is_resumable only for Fullrefresh streams #48343

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

artem1205
Copy link
Collaborator

What

passing is_resumable=False for report stream disabled incremental option

How

set is_resumable only for Fullrefresh streams

Review guide

  1. airbyte-integrations/connectors/source-amazon-ads/source_amazon_ads/streams/common.py

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

[skip ci]

Signed-off-by: Artem Inzhyyants <[email protected]>
@artem1205 artem1205 self-assigned this Nov 5, 2024
Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2024 5:11pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/amazon-ads labels Nov 5, 2024
Signed-off-by: Artem Inzhyyants <[email protected]>
Signed-off-by: Artem Inzhyyants <[email protected]>
@artem1205
Copy link
Collaborator Author

UPD:
tested reports with state {"__ab_no_cursor_state_message": True}, no error raised, new state was emitted correctly

@artem1205 artem1205 requested review from maxi297 and a team November 5, 2024 16:23
Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add mock server tests to validate the behavior change?

Signed-off-by: Artem Inzhyyants <[email protected]>
Signed-off-by: Artem Inzhyyants <[email protected]>
Signed-off-by: Artem Inzhyyants <[email protected]>
Signed-off-by: Artem Inzhyyants <[email protected]>
@artem1205 artem1205 marked this pull request as ready for review November 6, 2024 21:51
Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's me this. Should we validate a couple of connection in prod once this is release to validate that this behave as expected not only for report streams but also for portfolios (or another non resumable stream)?

@artem1205
Copy link
Collaborator Author

Should we validate a couple of connection in prod once this is release to validate that this behave as expected not only for report streams?

my main concern was only about incremental streams. The only incremental streams we have in this connector is *-reports, so I think its safe to merge this.

I'll run regression test to check this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/amazon-ads
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants