Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Destination Vectara: Improve title extraction logic #35206

Merged
merged 8 commits into from
Mar 6, 2024
Merged

🐛 Destination Vectara: Improve title extraction logic #35206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e45392d
bugfix in extraction of title for Vectara connector
ofermend Feb 13, 2024
cc4addd
bugfix
ofermend Feb 13, 2024
11f47a8
Merge branch 'master' into fix_title_get_vectara
aaronsteers Feb 14, 2024
63b8bce
fix title extraction
ofermend Feb 19, 2024
efbf3a5
Merge branch 'fix_title_get_vectara' of https://github.com/ofermend/a…
ofermend Feb 19, 2024
828455d
Merge branch 'master' into fix_title_get_vectara
aaronsteers Mar 5, 2024
4533068
bump connector version to 0.2.1
aaronsteers Mar 5, 2024
bfddabe
add v0.2.1 to changlog
aaronsteers Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/destination-vectara/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,5 @@ COPY destination_vectara ./destination_vectara
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.2.0
LABEL io.airbyte.version=0.2.1
LABEL io.airbyte.name=airbyte/destination-vectara
4 changes: 3 additions & 1 deletion airbyte-integrations/connectors/destination-vectara/destination_vectara/writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,9 @@ def _get_document_metadata(self, record: AirbyteRecordMessage) -> Dict[str, Any]
def _get_document_title(self, record: AirbyteRecordMessage) -> str:
title = "Untitled"
if self.title_field:
title = dpath.util.get(record.data, self.title_field)
found_title = dpath.util.values(record.data, self.title_field, separator=".")
if found_title:
title = found_title[0]
return title

def _get_stream_id(self, record: AirbyteRecordMessage) -> str:
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/destination-vectara/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ data:
connectorSubtype: database
connectorType: destination
definitionId: 102900e7-a236-4c94-83e4-a4189b99adc2
dockerImageTag: 0.2.0
dockerImageTag: 0.2.1
dockerRepository: airbyte/destination-vectara
githubIssueLabel: destination-vectara
icon: vectara.svg
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/destinations/vectara.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,5 +63,6 @@ In addition, in the connector UI you define two set of fields for this connector

| Version | Date | Pull Request | Subject |
| :------ | :--------- | :------------------------------------------------------- | :---------------------------------------------------------------- |
| 0.2.1 | 2024-03-05 | [35206](https://github.com/airbytehq/airbyte/pull/35206) | Fix: improved title parsing |
| 0.2.0 | 2024-01-29 | [34579](https://github.com/airbytehq/airbyte/pull/34579) | Add document title file configuration |
| 0.1.0 | 2023-11-10 | [31958](https://github.com/airbytehq/airbyte/pull/31958) | 🎉 New Destination: Vectara (Vector Database) |
Loading