Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Destination Vectara: Improve title extraction logic #35206

Merged
merged 8 commits into from
Mar 6, 2024
Merged

🐛 Destination Vectara: Improve title extraction logic #35206

merged 8 commits into from
Mar 6, 2024

Conversation

ofermend
Copy link
Contributor

What

  • extraction of title in Vectara connector had a bug. It used dpath.util.get() instead of dpath.util.values()

How

  • updated the code to use dpath.util.values()

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Feb 13, 2024
@vercel Vercel
Copy link

vercel bot commented Feb 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2024 8:58pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 13, 2024 •
edited by aaronsteers
Loading

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@marcosmarxm
Copy link
Member

Thanks @ofermend at the moment the connector integration tests are working. I'll run your change to check if they return to a green status.

@gHashTag
Copy link

Approve please

@marcosmarxm marcosmarxm changed the title bugfix in extraction of title for Vectara connector [destination-vectara] bugfix in extraction of title Feb 16, 2024
@marcosmarxm
Copy link
Member

@ofermend can you check AJ last comment? Thanks!

@ofermend
Copy link
Contributor Author

Oh sorry I missed this - yes, this looks like a great improvement. Let's use this suggestion.

@gHashTag
Copy link

Look forward to

aaronsteers
aaronsteers approved these changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@aaronsteers aaronsteers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update - and my apologies for letting this go stale.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Mar 5, 2024
@aaronsteers aaronsteers changed the title [destination-vectara] bugfix in extraction of title 🐛 Destination Vectara: Improve title extraction logic Mar 5, 2024
@aaronsteers aaronsteers merged commit aca8679 into airbytehq:master Mar 6, 2024
25 of 27 checks passed
xiaohansong pushed a commit that referenced this pull request Mar 7, 2024
@ofermend @xiaohansong
🐛 Destination Vectara: Improve title extraction logic (#35206)
d4c2655
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronsteers aaronsteers aaronsteers approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/destination/vectara
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ofermend @marcosmarxm @gHashTag @aaronsteers @octavia-squidington-iii