Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

25-validation-error-on-number-fields #29

Merged
merged 11 commits into from
Sep 10, 2024
Merged

25-validation-error-on-number-fields #29

merged 11 commits into from
Sep 10, 2024

Commits on Sep 6, 2024

  1. feat: Add unit tests for NutrientValue, Value, Specification, and NPK… 

    …Validation

This commit adds unit tests for the NutrientValue, Value, Specification, and NPKValidation classes. The tests cover both valid and invalid cases for each class, ensuring that the classes handle different edge cases correctly.

Issue #25
    @Endlessflow
    Endlessflow committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    3ec75f5 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2024

  1. fix: cleaned up superfluous test case in test_inspection.py and made … 

    …all tests pass in inspection.py
    @Endlessflow
    Endlessflow committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    8e1501b View commit details
    Browse the repository at this point in the history

  2. fix: lint fixes

    @Endlessflow
    Endlessflow committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    a6ade42 View commit details
    Browse the repository at this point in the history

  3. fix: removed duplicated npk testing from test_form.py

    @Endlessflow
    Endlessflow committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    52518fd View commit details
    Browse the repository at this point in the history

  4. fix: the mock inspection in test_form.py had the wrong values for spe… 

    …cifications.

The datastore accepts numerical values for humidity and solubility.

see: https://github.com/ai-cfia/ailab-datastore/blob/9a7d37f61a57aaa23d8ec59a376018b158c85ec0/datastore/db/metadata/inspection/__init__.py#L84C1-L85C1
    @Endlessflow
    Endlessflow committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    314beee View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. fix: adressed the changed from str to float in some of our schema values

    @Endlessflow
    Endlessflow committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    1c914b9 View commit details
    Browse the repository at this point in the history

  2. fix: test_form.py the mock object needed its values changed to float

    @Endlessflow
    Endlessflow committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    bed5896 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. use type instead of isinstance

    @k-allagbe
    k-allagbe committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    a23ca31 View commit details
    Browse the repository at this point in the history

  2. Revert "use type instead of isinstance" 

    This reverts commit a23ca31.
    @k-allagbe
    k-allagbe committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    f0991d7 View commit details
    Browse the repository at this point in the history

  3. use type instead of isinstance

    @k-allagbe
    k-allagbe committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    cd6f603 View commit details
    Browse the repository at this point in the history

  4. Revert "use type instead of isinstance" 

    This reverts commit cd6f603.
    @k-allagbe
    k-allagbe committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    ef7939d View commit details
    Browse the repository at this point in the history