25-validation-error-on-number-fields #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Validation This commit adds unit tests for the NutrientValue, Value, Specification, and NPKValidation classes. The tests cover both valid and invalid cases for each class, ensuring that the classes handle different edge cases correctly. Issue #25
…all tests pass in inspection.py
…cifications. The datastore accepts numerical values for humidity and solubility. see: https://github.com/ai-cfia/ailab-datastore/blob/9a7d37f61a57aaa23d8ec59a376018b158c85ec0/datastore/db/metadata/inspection/__init__.py#L84C1-L85C1
k-allagbe
reviewed
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alright. This PR introduces proper unit tests for the Inspection parsing in
test_inspection.py.I also made some fix in
inspection.pythat should make everything more robust and prevent complete failure when a field is invalid. The parsing process now tries to handle the invalid fields and in the event that the field can not be handled we default to null.@snakedye made a good point that eventually we probably want to find a way to be able to tell the difference between an actually empty value and a parsing error but for now I took the liberty to default to None for both.
@k-allagbe you can let me know if you still get issues with the datastore with this fix
closes #25