Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add operator.deploymentAnnotation value #1316

Merged
merged 1 commit into from
Sep 12, 2024
Merged

feat: Add operator.deploymentAnnotation value #1316

merged 1 commit into from
Sep 12, 2024

Conversation

hairmare
Copy link
Contributor

@hairmare hairmare commented Sep 12, 2024 •
edited
Loading

Description

Allows for setting annotations like argocd.argoproj.io/sync-wave on the operator deployment.

Issues

Checklist

  • This PR contains a description of the changes I'm making
  • I updated the version in Chart.yaml
  • I updated the changelog with an artifacthub.io/changes annotation in Chart.yaml, check the example in the documentation.
  • I updated applicable README.md files using pre-commit run
  • I documented any high-level concepts I'm introducing in docs/
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 12, 2024
open-dynaMIX
open-dynaMIX approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@open-dynaMIX open-dynaMIX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@hairmare hairmare marked this pull request as ready for review September 12, 2024 13:13
@hairmare hairmare requested a review from a team as a code owner September 12, 2024 13:13
maxthier
maxthier approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@maxthier maxthier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@hairmare hairmare merged commit b473d5e into adfinis:main Sep 12, 2024
3 checks passed
@hairmare hairmare deleted the fix/keycloak-operator/configurable-annotations-on-deployment branch September 12, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxthier maxthier maxthier approved these changes

@open-dynaMIX open-dynaMIX open-dynaMIX approved these changes

@eyenx eyenx Awaiting requested review from eyenx eyenx is a code owner automatically assigned from adfinis/helm-charts

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hairmare @open-dynaMIX @maxthier