Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New: Added mcq support for _canShowCorrectness #527

Merged
merged 2 commits into from
Oct 8, 2024
Merged

New: Added mcq support for _canShowCorrectness #527

merged 2 commits into from
Oct 8, 2024

Conversation

oliverfoster
Copy link
Member

part of adaptlearning/adapt_framework#3597

New

  • Added support for _canShowCorrectness

@oliverfoster oliverfoster self-assigned this Sep 10, 2024
kirsty-hames
kirsty-hames requested changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good thanks. Please see comment regarding selector name change.

less/plugins/adapt-contrib-mcq/mcq.less Outdated Show resolved Hide resolved
kirsty-hames
kirsty-hames approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected thanks

joe-allen-89
joe-allen-89 approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oliverfoster oliverfoster mentioned this pull request Sep 12, 2024
Merged
@simondate simondate self-requested a review October 3, 2024 15:46
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit 6bbb5c4 into master Oct 8, 2024
@oliverfoster oliverfoster deleted the issue/3597-mcq branch October 8, 2024 09:44
github-actions bot pushed a commit that referenced this pull request Oct 8, 2024
@semantic-release-bot
Chore(release): 9.21.0 [skip ci]
49b772e 
# [9.21.0](v9.20.1...v9.21.0) (2024-10-08)

### New

* Added mcq support for _canShowCorrectness (#527) ([6bbb5c4](6bbb5c4)), closes [#527](#527)
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024

🎉 This PR is included in version 9.21.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@kirsty-hames kirsty-hames kirsty-hames approved these changes

@simondate simondate simondate approved these changes

Assignees

@oliverfoster oliverfoster

Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oliverfoster @simondate @kirsty-hames @cahirodoherty-learningpool @joe-allen-89