Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New: Added support for _canShowCorrectness #224

Merged
merged 8 commits into from
Oct 8, 2024
Merged

New: Added support for _canShowCorrectness #224

merged 8 commits into from
Oct 8, 2024

Conversation

oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Sep 10, 2024 •
edited
Loading

part of adaptlearning/adapt_framework#3597

Allows option _canShowCorrectness instead of _canShowModelAnswer, to replace the associated toggle button and display correctness directly on the component.

image

New

  • Added support for _canShowCorrectness

requires
ref adaptlearning/adapt-contrib-core#582
ref adaptlearning/adapt-contrib-vanilla#527

@oliverfoster oliverfoster self-assigned this Sep 10, 2024
kirsty-hames
kirsty-hames approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected thanks. Please see comment raised regarding consistency of selector naming/nesting.

less/mcq.less Outdated Show resolved Hide resolved
kirsty-hames
kirsty-hames approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected thanks

joe-allen-89
joe-allen-89 approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All working and much nicer than toggle buttons 👍

@oliverfoster

This comment was marked as outdated.

Sign in to view
kirsty-hames

This comment was marked as resolved.

Sign in to view

@kirsty-hames

This comment was marked as resolved.

Sign in to view
@kirsty-hames
undo aria-disabled and raise as separate issue/pr
46c5a62 
...change isn't specific to _canShowModelAnswer functionality and will also apply to other question components
joe-allen-89
joe-allen-89 approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@simondate simondate self-requested a review October 3, 2024 16:13
simondate
simondate approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@simondate simondate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@oliverfoster oliverfoster merged commit be2018c into master Oct 8, 2024
@oliverfoster oliverfoster deleted the issue/3597 branch October 8, 2024 09:44
github-actions bot pushed a commit that referenced this pull request Oct 8, 2024
@semantic-release-bot
Chore(release): 7.5.0 [skip ci]
f21b8c3 
# [7.5.0](v7.4.3...v7.5.0) (2024-10-08)

### New

* Added support for _canShowCorrectness (#224) ([be2018c](be2018c)), closes [#224](#224)
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024

🎉 This PR is included in version 7.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

@kirsty-hames kirsty-hames kirsty-hames approved these changes

@simondate simondate simondate approved these changes

Assignees

@oliverfoster oliverfoster

Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oliverfoster @kirsty-hames @simondate @joe-allen-89