-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest version of rangeslider.js and fix various RTL issues #119
Update to latest version of rangeslider.js and fix various RTL issues #119
Conversation
can we wait till andreruffert/rangeslider.js#245 this PR gets merged into rangeSlider first ? , otherwise every time when we upgrade the rangeSlider we have to manually make the changes for RTL. |
Awaiting rangeslider.js library merge
@NayanKhedkar, is it possible for you to respond to @tomgreenfield's comments on andreruffert/rangeslider.js#245? This PR has been hanging around for some time. |
@brian-learningpool and @tomgreenfield initial css no more required.I updated css on same PR. |
Once andreruffert/rangeslider.js#245 is merged and we can come back to this again, please can we make sure to test against the framework using JQuery 3.1.x to check that version of JQuery doesn't still cause this bug? |
OK well there's been very little movement on the rangeslider repo in the past year (just four commits) so I appreciate what @sarveshwar-gavhane is saying I do thing we should just go ahead and then manually amend for the RTL fixes. |
sounds good @moloko and this PR has been hanging around near about a year(December to nov) now, i don't think so range Slider does care about RTL as we do in Adapt, they are not interested to either reviewing or merging |
I have updated the latest rangeslider.js(v2.3.1) with few changes to rtl feature. So can we go ahead and merge this PR, instead of waiting for the PR: andreruffert/rangeslider.js#245 to merge. @moloko @tomgreenfield @brian-learningpool can you please review the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, we're looking pretty good! I've tested this in RTL mode across IE11, Firefox, Chrome, Edge, Safari for iOS11 (iPhone and iPad) and it's all looking great. As far as I can see it fixes all the related issues.
fixes adaptlearning/adapt_framework#1318, adaptlearning/adapt_framework#1597 and adaptlearning/adapt_framework#1350