Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest version of rangeslider.js and fix various RTL issues #119

Merged
merged 7 commits into from
Nov 27, 2017
Merged

Update to latest version of rangeslider.js and fix various RTL issues #119

merged 7 commits into from
Nov 27, 2017

Conversation

NayanKhedkar
Copy link
Member

@NayanKhedkar NayanKhedkar commented Dec 19, 2016

tomgreenfield
tomgreenfield previously approved these changes Dec 19, 2016
@sarveshwar-gavhane
Copy link
Contributor

can we wait till andreruffert/rangeslider.js#245 this PR gets merged into rangeSlider first ? , otherwise every time when we upgrade the rangeSlider we have to manually make the changes for RTL.

@tomgreenfield tomgreenfield dismissed their stale review January 25, 2017 09:55

Awaiting rangeslider.js library merge

@brian-learningpool
Copy link
Member

@NayanKhedkar, is it possible for you to respond to @tomgreenfield's comments on andreruffert/rangeslider.js#245? This PR has been hanging around for some time.

@NayanKhedkar
Copy link
Member Author

@brian-learningpool and @tomgreenfield initial css no more required.I updated css on same PR.

@moloko
Copy link
Contributor

moloko commented Feb 28, 2017

Once andreruffert/rangeslider.js#245 is merged and we can come back to this again, please can we make sure to test against the framework using JQuery 3.1.x to check that version of JQuery doesn't still cause this bug?

@moloko
Copy link
Contributor

moloko commented Nov 10, 2017

OK well there's been very little movement on the rangeslider repo in the past year (just four commits) so I appreciate what @sarveshwar-gavhane is saying I do thing we should just go ahead and then manually amend for the RTL fixes.
hopefully getting this in will also allow us to finally update to JQuery v3.

@sarveshwar-gavhane
Copy link
Contributor

sounds good @moloko and this PR has been hanging around near about a year(December to nov) now, i don't think so range Slider does care about RTL as we do in Adapt, they are not interested to either reviewing or merging
i think we should move ahead if everyone is happy.

@NayanKhedkar
Copy link
Member Author

I have updated the latest rangeslider.js(v2.3.1) with few changes to rtl feature. So can we go ahead and merge this PR, instead of waiting for the PR: andreruffert/rangeslider.js#245 to merge. @moloko @tomgreenfield @brian-learningpool can you please review the PR?

@moloko moloko changed the title Issue/ 1318 and 1350 Update to latest version of rangeslider.js and fix various RTL issues Nov 24, 2017
Copy link
Contributor

@moloko moloko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, we're looking pretty good! I've tested this in RTL mode across IE11, Firefox, Chrome, Edge, Safari for iOS11 (iPhone and iPad) and it's all looking great. As far as I can see it fixes all the related issues.

@tomgreenfield tomgreenfield merged commit cf9d2fa into adaptlearning:master Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slider: wrong selection in RTL mode
6 participants