Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib-slider: Issues in RTL courses #1597

Closed
ryan-lynch opened this issue Jun 22, 2017 · 3 comments
Closed

contrib-slider: Issues in RTL courses #1597

ryan-lynch opened this issue Jun 22, 2017 · 3 comments

Comments

@ryan-lynch
Copy link
Contributor

ryan-lynch commented Jun 22, 2017

Slider component settings - Scale: 1-5 Correct answer: 3.

  • Resetting the component positions the slider to 5 instead of 1.
  • Clicking the slider area itself does not move the scale when I attempt to jump directly from 1-5 or 5-1, 2-4 or 4-2.
@sarveshwar-gavhane
Copy link
Contributor

probably if this PR's gets merged adaptlearning/adapt-contrib-slider#119 and andreruffert/rangeslider.js#245 resolved this issue.
remember #1318 issue

@moloko
Copy link
Contributor

moloko commented Jun 26, 2017

good point @sarveshwar-gavhane I had completely forgotten about that! @ryan-lynch could you see if the changes in adaptlearning/adapt-contrib-slider#119 solve the problems for you?

@ryan-lynch
Copy link
Contributor Author

ryan-lynch commented Jun 26, 2017

Hi @moloko - it appears to solve the issues, however after resetting the component, clicking on the numbers no longer moves the slider.

EDIT: Apologies, this was caused by my configuration and is not an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants