Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Missing Return Types #288

Open
steets250 opened this issue Feb 15, 2022 · 1 comment
Open

API Missing Return Types #288

steets250 opened this issue Feb 15, 2022 · 1 comment
Assignees
@maxwn04

Comments

@steets250
Copy link
Member

steets250 commented Feb 15, 2022 •
edited
Loading

We have the GetAllEventsResponse, but it's not currently in use.

membership-portal/api/controllers/EventController.ts

Line 113 in 9310daf

async getAllEvents(@QueryParams() options: EventSearchOptions, @AuthenticatedUser() user: UserModel) {

Same here:

membership-portal/api/controllers/MerchStoreController.ts

Line 248 in 9310daf

async cancelMerchOrder(@Params() params: UuidParam, @AuthenticatedUser() user: UserModel) {

@steets250 steets250 changed the title getAllEvents is missing a return type API Missing Return Types Feb 15, 2022
@shanekim28 shanekim28 mentioned this issue Mar 8, 2022
Merged
@nik-dange
Copy link
Member

@dowhep is this closed? It looks like Shane merged something in related to it from last year

@nik-dange nik-dange mentioned this issue Mar 6, 2024
Merged
13 tasks
@maxwn04 maxwn04 self-assigned this Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxwn04 maxwn04

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@steets250 @nik-dange @maxwn04