-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add return type for CancelMerchOrder #404
Conversation
Thanks for contributing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one nit but lgtm
Also make sure to bump package.json version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Catch with the missing return type information!
LGTM 🚀 🚀
As Nikhil noted, make sure to bump package.json version before merging
…into bugfix/add-missing-return-types merging from master
Info
Closes #288. (If there is no issue for this pull request yet, please create one or
delete this line if the pull request is for a very minor tweak).
Description
What changes did you make? List all distinct problems that this PR addresses. Explain any relevant
motivation or context.
Adds missing return type
Changes
Type of Change
expected)
workflows, linting, etc.)
If you've selected Patch, Minor, or Major as your change type, make sure to bump the version before merging in
package.json
!Testing
I have tested that my changes fully resolve the linked issue ...
Checklist
package.json
file.Screenshots
Please include a screenshot of your Postman testing passing successfully.