Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add return type for CancelMerchOrder #404

Merged
merged 7 commits into from
Mar 30, 2024

Conversation

maxwn04
Copy link
Contributor

@maxwn04 maxwn04 commented Feb 17, 2024

Info

Closes #288. (If there is no issue for this pull request yet, please create one or
delete this line if the pull request is for a very minor tweak).

Description

What changes did you make? List all distinct problems that this PR addresses. Explain any relevant
motivation or context.

Adds missing return type

Changes

  • Adds a api response type for cancel merch order

Type of Change

  • Patch (non-breaking change/bugfix)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to not work as
    expected)
  • Documentation (A change to a README/description)
  • Continuous Integration/DevOps Change (Related to deployment steps, continuous integration
    workflows, linting, etc.)
  • Other: (Fill In)

If you've selected Patch, Minor, or Major as your change type, make sure to bump the version before merging in package.json!

Testing

I have tested that my changes fully resolve the linked issue ...

  • locally.
  • on the testing API/testing database.
  • with appropriate Postman routes. Screenshots are included below.

Checklist

  • I have performed a self-review of my own code.
  • I have followed the style guidelines of this project.
  • I have appropriately edited the API version in the package.json file.
  • My changes produce no new warnings.

Screenshots

Please include a screenshot of your Postman testing passing successfully.

Copy link

Thanks for contributing!
If you've made changes to the API's functionality, please make sure to bump the package
version—see this guide to semantic versioning for details—and
document those changes as appropriate.

@maxwn04
Copy link
Contributor Author

maxwn04 commented Feb 27, 2024

image
Cancel Merch Order Postman

@maxwn04 maxwn04 changed the title Bugfix/add missing return types add missing return type to CancelMerchOrder Feb 29, 2024
@maxwn04 maxwn04 changed the title add missing return type to CancelMerchOrder Add return type for CancelMerchOrder Feb 29, 2024
Copy link
Member

@nik-dange nik-dange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit but lgtm

types/ApiResponses.ts Outdated Show resolved Hide resolved
@nik-dange
Copy link
Member

Also make sure to bump package.json version

Copy link
Contributor

@dowhep dowhep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Catch with the missing return type information!

LGTM 🚀 🚀

As Nikhil noted, make sure to bump package.json version before merging

@nik-dange nik-dange merged commit 51d727f into master Mar 30, 2024
5 checks passed
@nik-dange nik-dange deleted the bugfix/add-missing-return-types branch March 31, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants