Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update return type for getAllEvents #295

Merged
merged 3 commits into from
Mar 25, 2022
Merged

Update return type for getAllEvents #295

merged 3 commits into from
Mar 25, 2022

Conversation

shanekim28
Copy link
Contributor

Updated return type of getAllEvents to utilize the GetAllEventsResponse DTO

Responds partly to #288

Held off on updating the response to cancelMerchOrder. There was a discrepancy in the behaviours of cancelMerchOrder, fulfillMerchOrderItems, and rescheduleOrderPickup. I noticed fulfillMerchOrderItems returns a FulfillMerchOrderResponse DTO and modifies the respective order, but the other two routes do not return anything despite modifying the model. Not sure if this was intended, but may be worth looking into for consistency.

@github-actions
Copy link

github-actions bot commented Mar 8, 2022

Thanks for contributing! If you've made changes to the API's functionality, please make sure to bump the package version—see this guide to semantic versioning for details—and document those changes as appropriate.

@shravanhariharan2
Copy link
Collaborator

Thanks for contribuing! Our type system for our controllers and services are currently a bit incomplete / inconsistent (e.g. missing return types for controllers, returning Public types vs. Model types in the services, to name a few), and we're looking to refactor these during our upcoming undertaking of exporting a types package. We're going to discuss these discrepancies with the rest of the development team to iron out where responses should be returned vs. where they shouldn't (i.e. figuring out where the frontend should or shouldn't be using the responses to their API calls), so you can expect that to be resolved within a few weeks.

For now, we can merge in this PR to patch the getAllEvents route, and we can handle the rest of the type discrepancies in future PRs relating to that package refactor.

@shravanhariharan2 shravanhariharan2 merged commit 3fdf160 into master Mar 25, 2022
@shravanhariharan2 shravanhariharan2 deleted the types-update branch March 25, 2022 19:54
nick-ls pushed a commit to nick-ls/membership-portal that referenced this pull request Aug 6, 2024
* Update return type for getAllEvents

* Fixed linting issues

Co-authored-by: Shravan Hariharan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants