Update return type for getAllEvents #295
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated return type of
getAllEvents
to utilize theGetAllEventsResponse
DTOResponds partly to #288
Held off on updating the response to
cancelMerchOrder
. There was a discrepancy in the behaviours ofcancelMerchOrder
,fulfillMerchOrderItems
, andrescheduleOrderPickup
. I noticedfulfillMerchOrderItems
returns aFulfillMerchOrderResponse
DTO and modifies the respective order, but the other two routes do not return anything despite modifying the model. Not sure if this was intended, but may be worth looking into for consistency.