Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for DENTNet #128

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

henrikdent
Copy link

@henrikdent henrikdent commented Aug 21, 2024

Enable Ledger for DENTNet (https://dentnet.io).

(Not sure what the process is now with the generic app but polkadot-js/common seems to rely on this list to enable support in the apps & extension)

🔗 zboto Link

@emmanuelm41
Copy link
Member

Hey @henrikdent! We just get to know that PJS common relies on this list to enable ledger support. For the new app (the generic one(, it should not be required, as the app just works out of the box (if the chain supports it). If that is so, we can add the chain anyway. Can you please point me to the place where PJS uses this listo to enable ledger support? I want to take a look at it.

@henrikdent
Copy link
Author

Hey @henrikdent! We just get to know that PJS common relies on this list to enable ledger support. For the new app (the generic one(, it should not be required, as the app just works out of the box (if the chain supports it). If that is so, we can add the chain anyway. Can you please point me to the place where PJS uses this listo to enable ledger support? I want to take a look at it.

Hi @emmanuelm41, thanks - coincidentally they just removed the dependency yesterday in this commit. You can see the diff there where it used supportedApps from this repo. With that I don't think the merge is strictly required, but don't know if there might be other projects depending this list?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants