Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add integritee chain support #134

Closed
wants to merge 4 commits into from
Closed

add integritee chain support #134

wants to merge 4 commits into from

Conversation

brenzi
Copy link

@brenzi brenzi commented Sep 3, 2024

The Integritee Network runtime is ready for ledger support. Adding it here

slip44 registered here: satoshilabs/slips#1785

🔗 zboto Link

Encointer is a systemchain on Kusama and shares the same native KSM token as a teleporter
@brenzi brenzi changed the title add encointer chain support add encointer and integritee chain support Sep 3, 2024
Copy link
Member

@ainhoa-a ainhoa-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Encointer should not use the same address type as kusama It should be first registered here https://github.com/paritytech/ss58-registry/blob/main/ss58-registry.json and get its own number.
Integritee is ok

@brenzi
Copy link
Author

brenzi commented Sep 5, 2024

@ainhoa-a I think you misunderstand. Encointer is a systemchain and its native token is the KSM, therefore, like all other system chains, it should use the same ss58 prefix.

However, I just realized Encointer is included in a pending PR #130
therefore, I'll remove Encointer from this PR

@brenzi brenzi changed the title add encointer and integritee chain support add integritee chain support Sep 5, 2024
@ainhoa-a
Copy link
Member

ainhoa-a commented Sep 5, 2024

Hi @brenzi ok understood on the prefix, but why are you using a different cla than the generic app? are you planning to have a dedicated app?
If you're planing on using the generic you should use CLA 0xF9

@brenzi
Copy link
Author

brenzi commented Sep 6, 2024

@ainhoa-a I'm confused. As this PR is only about integritee now, I guess you're talking about that.

The README in this repo says

Take the last used CLA and pick the following number

that's what I did and it seems to be what everyone else did.

@emmanuelm41
Copy link
Member

Hey @brenzi! Thanks for the contribution. Just to double check, this chain (Integritee) is not levering the new feature on polkadot for generic, right? Ainhoa was asking about the CLA, because in case you are going to use the new app (generic one), there is no need to define the app on this file. You can just use the GenericApp class. In case you are using the legacy app, then it is ok to take the latest value and increase it by 1.

@brenzi
Copy link
Author

brenzi commented Sep 11, 2024

The generic app is fine for us, thanks for the info. Would be nice if you could make this really obvious in the docs and the readme in this repo

@brenzi brenzi closed this Sep 11, 2024
@emmanuelm41
Copy link
Member

@brenzi I am checking this, as it might be still necessary to add it as PJS needs it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants