[wip] adjust target model to support 5x4 #1106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makslevental
force-pushed
the
virtualized_target_model
branch
4 times, most recently
from
aeeb498
to
a373505
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
makslevental
force-pushed
the
virtualized_target_model
branch
3 times, most recently
from
9688105
to
9b631dc
Compare
makslevental
force-pushed
the
virtualized_target_model
branch
from
197d2e5
to
c223dfc
Compare
|
Do you have a new test for 5 columns? |
In another branch yes |
stephenneuendorffer
requested changes
Mar 11, 2024
| location, | ||
| AIEDeviceAttr::get(builder.getContext(), AIEDevice::xcvc1902)); | ||
| location, AIEDeviceAttr::get(builder.getContext(), AIEDevice::xcvc1902), | ||
| /*virtualized*/ builder.getBoolAttr(true)); |
There was a problem hiding this comment.
This seems wrong, because the vc1902 is not virtualized.
| @@ -27,9 +27,9 @@ struct AIECanonicalizeDevicePass | |||
|
|
|||
| ModuleOp moduleOp = getOperation(); | |||
|
|
|||
| for (auto deviceOp : moduleOp.getOps<AIETarget>()) { | |||
| for (auto deviceOp : moduleOp.getOps<DeviceOp>()) { | |||
There was a problem hiding this comment.
Why did you need this?
There was a problem hiding this comment.
I removed that interface - there was only one op that implemented it AIEDeviceOp
| public: | ||
| AIETargetModel() = default; | ||
| AIETargetModel(bool virtualized = true) : virtualized(virtualized) {} |
There was a problem hiding this comment.
This seems insufficient, since we actually have many potential 'virtual' targets (for instance, of different column widths.
makslevental
force-pushed
the
virtualized_target_model
branch
from
c223dfc
to
7cf4ee8
Compare
|
Obsolete with #1443 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR parameterizes
AIETargetModelwith abool virtualized, which is then queried when checkingisShimNOCTile(col, row) || isShimPLTile(col, row). Note, I have only updatedIPUTargetModelto the correct result because that is the only one I am familiar with (the rest fallback tovirtualized=true, i.e., the current behavior).Note, this PR touched a lot of lines only because the models were
staticprior and had to be updated toshared_ptrs.fixes #1094