Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add patterns for post formats Link and Audio #441

Merged
merged 4 commits into from
Sep 27, 2024
Merged

Conversation

jasmussen
Copy link
Contributor

Description

Along with a #295, maybe this one helps address #17.

This PR adds two new patterns, Link format and Quote format. The motivation is this:

  • Post format archives already exist, i.e. if you go to /type/quote you will see quote-based post formats.
  • In a large amount of the post formats registered in Add theme support for post formats #295 (standard, quote, video, gallery), the blocks with their default styles represent a post format styling, both on individual posts and in archive pages.
  • The underlying templates to present post formats with a unique appearance is still lacking in places, so perhaps it's not worth having dedicated archive templates that change the apperance from what the post format will look like on its permalink.

Specifically the Link and Audio formats, though, are harder to get visually right. This PR creates a shortcut for you, a few patterns. It's not clear whether this is a good idea or not, but if it's an idea to try, the PR would need to land soon.

Figma design for Link format:

figma-link

Corresponding pattern design:

link format

Figma design for audio:

figma-audio

Corresponding pattern design:

audio format

Noting the discrepancies above, we cannot style the audio player.

Separately, I tried categorizing these as post formats, and featured, though something here is missing, and I'm not actually seeing these show up. Let me know my mistake here!

@jasmussen jasmussen added the [Type] Enhancement A suggestion for improvement. label Sep 27, 2024
@jasmussen jasmussen self-assigned this Sep 27, 2024
Copy link

github-actions bot commented Sep 27, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: jasmussen <[email protected]>
Co-authored-by: juanfra <[email protected]>
Co-authored-by: carolinan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

github-actions bot commented Sep 27, 2024

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@carolinan
Copy link
Contributor

Post format archives already exist, i.e. if you go to /type/quote you will see quote-based post formats.

Yes it uses archive.html

@carolinan
Copy link
Contributor

Custom categories need to be registered: https://github.com/WordPress/twentytwentyfive/blob/trunk/functions.php#L113

@carolinan
Copy link
Contributor

For the audio, is it not possible to make the image the same height as the other content?

@jasmussen
Copy link
Contributor Author

I'll take a look at registering that cateogory. We can always remove it if we think it's a bad idea.

For the audio, I can probably do something with a Stack block, but in this case I wanted to try and keep the perfect square shape of the image, which feels standard for podcasts. What do you think?

@jasmussen
Copy link
Contributor Author

Something's not working with my code, would appreciate a gut-check. Feel free to push if I'm missing something obvious. For now I moved these to the "Pages" category.

@carolinan
Copy link
Contributor

I see that the category is fixed.

@carolinan
Copy link
Contributor

Thank you :)

@carolinan carolinan merged commit f1fe869 into trunk Sep 27, 2024
4 checks passed
@carolinan
Copy link
Contributor

Oh the Stories link pattern has the registered trademark symbol, it needs to be removed.

@jasmussen
Copy link
Contributor Author

Oh the Stories link pattern has the registered trademark symbol, it needs to be removed.

On it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants