-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add patterns for post formats Link and Audio #441
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Preview changesYou can preview these changes by following the link below: I will update this comment with the latest preview links as you push more changes to this PR. |
Yes it uses archive.html |
Custom categories need to be registered: https://github.com/WordPress/twentytwentyfive/blob/trunk/functions.php#L113 |
For the audio, is it not possible to make the image the same height as the other content? |
I'll take a look at registering that cateogory. We can always remove it if we think it's a bad idea. For the audio, I can probably do something with a Stack block, but in this case I wanted to try and keep the perfect square shape of the image, which feels standard for podcasts. What do you think? |
Something's not working with my code, would appreciate a gut-check. Feel free to push if I'm missing something obvious. For now I moved these to the "Pages" category. |
I see that the category is fixed. |
Thank you :) |
Oh the Stories link pattern has the registered trademark symbol, it needs to be removed. |
On it. |
Description
Along with a #295, maybe this one helps address #17.
This PR adds two new patterns, Link format and Quote format. The motivation is this:
Specifically the Link and Audio formats, though, are harder to get visually right. This PR creates a shortcut for you, a few patterns. It's not clear whether this is a good idea or not, but if it's an idea to try, the PR would need to land soon.
Figma design for Link format:
Corresponding pattern design:
Figma design for audio:
Corresponding pattern design:
Noting the discrepancies above, we cannot style the audio player.
Separately, I tried categorizing these as post formats, and featured, though something here is missing, and I'm not actually seeing these show up. Let me know my mistake here!