-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add theme support for post formats #295
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Preview changesYou can preview these changes by following the link below: I will update this comment with the latest preview links as you push more changes to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Carolina, so the idea is to squeeze it in before beta 1 in case we can make it for 6.7. Right?
functions.php
Outdated
* @since Twenty Twenty-Five 1.0 | ||
* @return void | ||
*/ | ||
function twentytwentyfive_post_format_setup() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wrap this in an if ( ! function_exists(...
like the other functions in the file.
Co-authored-by: Juan Aldasoro <[email protected]>
Co-authored-by: Juan Aldasoro <[email protected]>
I do not believe there is enough support or developers available, but, yes. |
Appreciate this PR. Do we need additional templates or is this ready to land? |
There should be archive templates for each supported format. And possibly for the singles. The good thing is there are Figma designs for the singles. |
I'll see if I can do anything to help here. |
Following up, I created #441 with a summary of some learnings. One path forward I can see is: we register these formats, but we don't add templates for them. And we create a few patterns for the slightly more elaborate formats, Link and Audio. Let me know your thoughts. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels worth trying, and it will be easier to rewind if we need to, than add at a later time.
Description
I have re-opened this PR after the discussion in #17
If we want the theme to have partial support for post formats in 6.7, it needs to be added to the theme before Beta 1, since it is an enhancement. Then if it does not work well enough, it can be removed before the string freeze.
This PR:
Testing Instructions
This can be tested with the latest version of Gutenberg active.
type/link/
after your test domain in the browser address bar.