Adds pattern for hero left align description #324
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,24 @@ | ||||||
| <?php | ||||||
| /** | ||||||
| * Title: Hero Left Align Description | ||||||
| * Slug: twentytwentyfive/hero-left-align-description | ||||||
| * Categories: banner, call-to-action, featured | ||||||
| * Description: A hero with a left align description. | ||||||
| * | ||||||
| * @package WordPress | ||||||
| * @subpackage Twenty_Twenty_Five | ||||||
| * @since Twenty Twenty-Five 1.0 | ||||||
| */ | ||||||
|
|
||||||
| ?> | ||||||
|
|
||||||
| <!-- wp:group {"metadata":{"categories":["featured"],"patternName":"twentytwentyfive/hero-left-align-description","name":"Hero Left Align Description"},"align":"full","style":{"spacing":{"padding":{"right":"var:preset|spacing|40","left":"var:preset|spacing|40","top":"var:preset|spacing|80","bottom":"var:preset|spacing|80"},"margin":{"top":"0","bottom":"0"}},"dimensions":{"minHeight":"0vh"}},"layout":{"type":"constrained"}} --> | ||||||
|
There was a problem hiding this comment.
Suggested change
Remove metadata |
||||||
| <div class="wp-block-group alignfull" style="min-height:0vh;margin-top:0;margin-bottom:0;padding-top:var(--wp--preset--spacing--80);padding-right:var(--wp--preset--spacing--40);padding-bottom:var(--wp--preset--spacing--80);padding-left:var(--wp--preset--spacing--40)"><!-- wp:heading {"textAlign":"left","level":1,"align":"wide"} --> | ||||||
| <h1 class="wp-block-heading alignwide has-text-align-left"> | ||||||
| <?php echo esc_html_x( 'We\'re', 'Heading start for description', 'twentytwentyfive' ); ?> | ||||||
| <strong><?php echo esc_html_x( 'Fleurs', 'Heading emphasis for description', 'twentytwentyfive' ); ?></strong> | ||||||
| <?php echo esc_html_x( ', our mission is to deliver exquisite flower arrangements that not only adorn living spaces but also inspire a deeper appreciation for natural beauty.', 'Heading end for description', 'twentytwentyfive' ); ?> | ||||||
| </h1> | ||||||
|
There was a problem hiding this comment. This will be very difficult for translators to translate as 3 separate strings, it would be better to use one string, even if it contains HTML. |
||||||
| <!-- /wp:heading --> | ||||||
| </div> | ||||||
| <!-- /wp:group --> | ||||||
|
There was a problem hiding this comment. There needs to be a single empty line at the end of the file. |
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't this just be "Hero" or "Hero section" ?