Adds pattern for hero left align description #324
Conversation
|
|
||
| ?> | ||
|
|
||
| <!-- wp:group {"metadata":{"categories":["featured"],"patternName":"twentytwentyfive/hero-left-align-description","name":"Hero Left Align Description"},"align":"full","style":{"spacing":{"padding":{"right":"var:preset|spacing|40","left":"var:preset|spacing|40","top":"var:preset|spacing|80","bottom":"var:preset|spacing|80"},"margin":{"top":"0","bottom":"0"}},"dimensions":{"minHeight":"0vh"}},"layout":{"type":"constrained"}} --> |
There was a problem hiding this comment.
| <!-- wp:group {"metadata":{"categories":["featured"],"patternName":"twentytwentyfive/hero-left-align-description","name":"Hero Left Align Description"},"align":"full","style":{"spacing":{"padding":{"right":"var:preset|spacing|40","left":"var:preset|spacing|40","top":"var:preset|spacing|80","bottom":"var:preset|spacing|80"},"margin":{"top":"0","bottom":"0"}},"dimensions":{"minHeight":"0vh"}},"layout":{"type":"constrained"}} --> | |
| <!-- wp:group {"align":"full","style":{"spacing":{"padding":{"right":"var:preset|spacing|40","left":"var:preset|spacing|40","top":"var:preset|spacing|80","bottom":"var:preset|spacing|80"},"margin":{"top":"0","bottom":"0"}},"dimensions":{"minHeight":"0vh"}},"layout":{"type":"constrained"}} --> |
Remove metadata
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @[email protected]. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| </h1> | ||
| <!-- /wp:heading --> | ||
| </div> | ||
| <!-- /wp:group --> |
There was a problem hiding this comment.
There needs to be a single empty line at the end of the file.
| <?php echo esc_html_x( 'We\'re', 'Heading start for description', 'twentytwentyfive' ); ?> | ||
| <strong><?php echo esc_html_x( 'Fleurs', 'Heading emphasis for description', 'twentytwentyfive' ); ?></strong> | ||
| <?php echo esc_html_x( ', our mission is to deliver exquisite flower arrangements that not only adorn living spaces but also inspire a deeper appreciation for natural beauty.', 'Heading end for description', 'twentytwentyfive' ); ?> | ||
| </h1> |
There was a problem hiding this comment.
This will be very difficult for translators to translate as 3 separate strings, it would be better to use one string, even if it contains HTML.
| @@ -0,0 +1,24 @@ | |||
| <?php | |||
| /** | |||
| * Title: Hero Left Align Description | |||
There was a problem hiding this comment.
Can't this just be "Hero" or "Hero section" ?
Description
Pattern for #89
Notes
This uses 'bold' in the translation wrap, this might be something to do in alternative options but works as initial idea to keep translation.