Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/source datamodel #500

Open
wants to merge 100 commits into
base: develop
Choose a base branch
from
Open

Feature/source datamodel #500

wants to merge 100 commits into from

Conversation

JeltevanBoheemen
Copy link
Contributor

@JeltevanBoheemen JeltevanBoheemen commented Sep 26, 2021 •
edited
Loading

@jgonggrijp @BeritJanssen

I wasn't able to finish this, please see below for thing that should (probably) be resolved before this can be considered done

  • Either:
  • Use item editors for optional fields (the permitted datatypes will provide ample hints for what is valid for which field). I got this sort of working, but as individual editors. These had a 'remove' button, an empty dropdown, and I didn't get around to actually sending their data to the backend. Next on my list was using a MultiField editor.
  • Provide tooltips and validation for the ISO-date/freetext fields and repository.
  • Frontend tests need to be fixed
  • Backend migrations need some testing. I might have missed some cases, only tested and confirmed migration working by hand.
  • The source types will need to be discusses with Francois. The TFO ontology is too limited for use in READ-IT. For now, non-replacable source types remain unchanged.

Please let me know if I can answers any questions, I'll be reading and answering my mail concerning this PR.

@jgonggrijp jgonggrijp mentioned this pull request Oct 13, 2021
Open
@jgonggrijp jgonggrijp mentioned this pull request Oct 27, 2021
Closed
jgonggrijp and others added 29 commits May 20, 2023 17:35
@jgonggrijp
Fix improper const/let in front:source-metadata/-view:renderValues
13b819c 
Ref #37 #517
@jgonggrijp
Remove superfluous padding from source editing form (#37 #517 #175)
98ec54d
@jgonggrijp
Put editor and publisher fields on separate rows (#37 #517)
bde1610
@jgonggrijp
Use static inputs in readonly source metadata view (#37 #517)
9c8809b
@jgonggrijp
Hide help text in static source metadata form (#37 #517)
64d0ee9
@jgonggrijp
Fix notorious capitalization error in source upload form
50e5057
@jgonggrijp
Regenerate the translation files (#37 #517 #451)
2600570
@jgonggrijp
Remove superfluous div wrapper from source meta date view (#37 #517)
43df2a9
@jgonggrijp
Use table layout for static source metadata form (#37 #517)
d30f5cb
@jgonggrijp
Source metadata access toggle label belongs outside of div.control
98d1531 
Ref #37 #517
@jgonggrijp
Make publicity radio buttons disabled when applicable (#37 #517)
6a7aaab
@jgonggrijp
Remove the is-static class again when editing (#37 #517)
ec37b6f
@jgonggrijp
souceTypeSelect is a class, not an ID (#37 #517)
7e05ad1
@jgonggrijp
Give static source metadata some breathing room (#37 #517)
69f8629
@jgonggrijp
Normalize readonly property on source meta form (#37 #517)
3551a10
@jgonggrijp
Restore file change handler in frontend SourceUploadForm (#37 #517)
aab84ec 
The render(Container) method was never the right place to bind events
to child elements, but we got away with it when the form was still a
monolithic view. In the new composite situation, the element in
question does not exist yet during the call to renderContainer. The
conventional delegate mechanism completely avoids this problem.
@jgonggrijp
Align backend assumptions with frontend reality of field names
e6e845f 
Ref #37 #517
@jgonggrijp
Include the rdf:type when saving a source (#37 #517)
70b14c4
@jgonggrijp
Add native conversion for xsd:date to frontend (#37 #517)
413d2c0
@jgonggrijp
Render timeless dates correctly in source metadata form (#37 #517)
c19282e
@jgonggrijp
Render all pre-existing values correctly in source meta form (#37 #517)
fae948f
@jgonggrijp
Submit is an event name, not a class name (#37 #517)
4323485
@jgonggrijp
No submit event without a <form> (#37 #517)
3189b30
@jgonggrijp
updateModel should be called on *every* change event, not just for th…
5203c2e 
…e .input class (#37 #517)
@jgonggrijp
Skip existing value check in SourceMetadata#updateModel (#37 #517)
1ad3bba 
The event was effectively triggered unconditionally, as an identity
comparison against a literal array will always be false.
@jgonggrijp
Read values from radio buttons using :checked (#37 #517)
71e276d
@JeltevanBoheemen
Don't use pip-sync for backend requirements
2689792
@JeltevanBoheemen
Remove pinned jsonld dependency
5e203c4
@JeltevanBoheemen
downgrade canvas to 2.6.1
f10dea7
@JeltevanBoheemen JeltevanBoheemen mentioned this pull request Jul 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JeltevanBoheemen @BeritJanssen @jgonggrijp