Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove need for permission to upload sources #508

Open
jgonggrijp opened this issue Oct 13, 2021 · 2 comments
Open

Remove need for permission to upload sources #508

jgonggrijp opened this issue Oct 13, 2021 · 2 comments
Labels
consortium agreement Was agreed with the consortium
Milestone

Comments

@jgonggrijp
Copy link
Member

When uploading sources first became possible, it was available to all registered users. Soon after, @alexhebing added a restriction to allow this only to admins. I could not find any documented rationale for this restriction, but it provides some protection against spam, so that might have been it. In #262, we discussed that uploading sources should rather be a privilege that can be independent from being an admin. This is how we ended up in the current situation. More historical references can be found through #175.

Post-development, keeping this restriction in place is undesirable for two reasons: (1) since the beginning, the intent of the project has been to be open to the general public (compare #180, #418) and (2) maintaining the restriction implies that someone has to be available to give the privilege to new users.

Removing the restriction is fast and straightforward, since it only requires making code that is conditional on the privilege unconditional instead, or conditional on being authenticated. However, we should hold off on this until #478 is in place, in order to not open the floodgates for spambots. It will also be most practical to wait until after #444/#500, and the upload form should explicitly advice people not to upload overly long sources (#391).

@JosedeKruif
Copy link
Collaborator

JosedeKruif commented Oct 14, 2021 via email

@jgonggrijp
Copy link
Member Author

Right. Shaf and Brigitte have both confirmed that they want the restriction removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consortium agreement Was agreed with the consortium
Projects
None yet
Development

No branches or pull requests

2 participants