Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add class methods to check_pop_data #247

Merged
merged 3 commits into from
Sep 6, 2024
Merged

add class methods to check_pop_data #247

merged 3 commits into from
Sep 6, 2024

Conversation

chrisorwa
Copy link
Collaborator

Replace direct calling on pop_data attributes with class methods.

@chrisorwa chrisorwa linked an issue Sep 2, 2024 that may be closed by this pull request
update check_pop_data() to use class methods instead of accessing attributes directly #244
Closed
@codecov Codecov
Copy link

codecov bot commented Sep 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
R/check_pop_data.R 100.00% <100.00%> (ø)

d-morrison
d-morrison approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@d-morrison d-morrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks!

@d-morrison d-morrison merged commit d85b377 into main Sep 6, 2024
12 checks passed
@d-morrison d-morrison deleted the update-check_pop_data-to-use-class-methods branch September 6, 2024 18:05
@d-morrison d-morrison restored the update-check_pop_data-to-use-class-methods branch September 10, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-morrison d-morrison d-morrison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update check_pop_data() to use class methods instead of accessing attributes directly
2 participants
@chrisorwa @d-morrison