Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update check_pop_data() to use class methods instead of accessing attributes directly #244

Closed
d-morrison opened this issue Aug 29, 2024 · 0 comments · Fixed by #247
Closed

update check_pop_data() to use class methods instead of accessing attributes directly #244

d-morrison opened this issue Aug 29, 2024 · 0 comments · Fixed by #247
Assignees
@chrisorwa
Labels
backend internal functions, etc tech debt simplifying backend code, etc.
Milestone
v2.0 release

Comments

@d-morrison
Copy link
Member

e.g.

serocalculator/R/check_pop_data.R

Line 24 in 9375ec0

missing_age <- is.element(attributes(pop_data)$age_var, names(pop_data))

@d-morrison d-morrison added tech debt simplifying backend code, etc. backend internal functions, etc labels Aug 29, 2024
@d-morrison d-morrison added this to the v2.0 release milestone Aug 29, 2024
@chrisorwa chrisorwa self-assigned this Sep 2, 2024
@chrisorwa chrisorwa linked a pull request Sep 2, 2024 that will close this issue
add class methods to check_pop_data #247
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisorwa chrisorwa

Labels
backend internal functions, etc tech debt simplifying backend code, etc.
Projects
None yet
Milestone
v2.0 release
Development

Successfully merging a pull request may close this issue.

add class methods to check_pop_data UCD-SERG/serocalculator
2 participants
@chrisorwa @d-morrison