Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quandify CubicMeter 1.1 support #824

Merged
merged 10 commits into from
Sep 20, 2024

Conversation

peter-quandify
Copy link
Contributor

Summary

Added support for

  • CubicMeter 1.1 Plastic
  • CubicMeter 1.1 Copper

Changes

Added files to the vendor folder for device settings and decoding

Checklist for Reviewers

  • Title and description should be descriptive (Not just a serial number for example).
  • profileIDs should not be vendorID and should be a unique value for every profile.
  • All devices should be listed in the vendor's index.yaml file.
  • Firmware versions can not be changed.
  • At least 1 image per device and should be transparent.

Notes for Reviewers

Is the data structure returned from the decodeUplink correct?
We could not find appropriate fields in the normalizedOutput that would correspond to

  • Water temperature max
  • Water temperature min
  • Ambient temperature
  • Total volume

But we found leak status and battery level, should we add those to the normalized output object?

Release Notes

CubicMeter 1.1 Plastic support
CubicMeter 1.1 Copper support

@CLAassistant
Copy link

CLAassistant commented Sep 18, 2024

CLA assistant check
All committers have signed the CLA.

@LDannijs
Copy link
Contributor

Hello @peter-quandify,

Is the data structure returned from the decodeUplink correct?

Have you ran make validate? that will check the files if they are outputting the correct structure. I ran it on you files and it seems to be correct but if the structure wasn't correct the make validate would catch it.

We could not find appropriate fields in the normalizedOutput that would correspond to

  • Water temperature max
  • Water temperature min
  • Ambient temperature
  • Total volume

But we found leak status and battery level, should we add those to the normalized output object?

You are technically free to add your own fields to our schema, if you know how to (documentation). Otherwise adding as much as you can to the normalized output is recommended, as they can help out users a lot.

@Jaime-Trinidad Jaime-Trinidad merged commit 41f0da9 into TheThingsNetwork:master Sep 20, 2024
2 checks passed
@peter-quandify
Copy link
Contributor Author

The normalized formatter is missing the update schema definition to work properly, which we are currently working on adding.

@peter-quandify peter-quandify deleted the quandify/cubicmeter branch October 10, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants