Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate from capi to papi #1410

Merged
merged 18 commits into from
Aug 22, 2024
Merged

feat: migrate from capi to papi #1410

merged 18 commits into from
Aug 22, 2024

Conversation

alecdwm
Copy link
Member

@alecdwm alecdwm commented Apr 16, 2024

This PR upgrades all of our substrate balance modules to use papi for:

  • Metadata compacting
  • SCALE encoding
  • SCALE decoding
  • callData encoding (for token transfers on pallets which need an onChainId / tokenId / currencyId as a parameter)

Side effects of Papito use may include, but are not limited to:

  • Increased developer serotonin levels 🧠
  • Lower system temperature 🌡️
  • Reduced browser memory usage 🐏
  • Improved compatibility for 🥔 computers

Papi moodboard

@alecdwm alecdwm added enhancement New feature or request quick-fix labels Apr 16, 2024
@alecdwm alecdwm self-assigned this Apr 16, 2024
Copy link
Contributor

github-actions bot commented Apr 16, 2024

🦋 Changeset(s) detected

This PR includes changeset(s) for the following changed packages:

"@talismn/balances"
"@talismn/balances-react"
"@talismn/chaindata-provider"
"@talismn/on-chain-id"
"@talismn/scale"

Not sure what this means? Click here to learn what changesets are.

@0xKheops
Copy link
Contributor

this PR is making me horny

Copy link

socket-security bot commented Jul 3, 2024

@alecdwm alecdwm marked this pull request as ready for review July 4, 2024 01:22
@alecdwm alecdwm changed the title feat: scale-ts feat: migrate from capi to papito/polkadot-api Jul 4, 2024
@alecdwm alecdwm changed the title feat: migrate from capi to papito/polkadot-api feat: migrate from capi to papito/polkadot-api Jul 4, 2024
@alecdwm alecdwm force-pushed the feat/scale-ts branch 2 times, most recently from 37734d9 to 668eb50 Compare July 8, 2024 00:38
Copy link

socket-security bot commented Jul 8, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@alecdwm alecdwm force-pushed the feat/scale-ts branch 3 times, most recently from 3f2caf1 to bb5e840 Compare July 17, 2024 02:08
@alecdwm alecdwm force-pushed the feat/scale-ts branch 2 times, most recently from ae9f416 to 3461c92 Compare August 14, 2024 00:57
@alecdwm alecdwm force-pushed the feat/scale-ts branch 2 times, most recently from d50d573 to 1af05a7 Compare August 20, 2024 06:21
@alecdwm alecdwm changed the title feat: migrate from capi to papito/polkadot-api feat: migrate from capi to papi Aug 21, 2024
Copy link
Contributor

@0xKheops 0xKheops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFGTM!! Big one!

@alecdwm alecdwm merged commit ea4d120 into dev Aug 22, 2024
6 checks passed
@alecdwm alecdwm deleted the feat/scale-ts branch August 22, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request quick-fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants