fix: remap miniMetadata lookup ids to placate TypeRegistry #1417
Conversation
🦋 Changeset(s) detectedThis PR includes changeset(s) for the following changed packages: Not sure what this means? Click here to learn what changesets are. |
| ? !!token.evmNetwork?.id || chainsById[token.chain?.id ?? ""]?.account === "secp256k1" | ||
| : !!token.chain?.id | ||
| ? token.evmNetwork?.id || chainsById[token.chain?.id ?? ""]?.account === "secp256k1" | ||
| : token.chain?.id && chainsById[token.chain?.id ?? ""]?.account !== "secp256k1" |
There was a problem hiding this comment.
New exclusion: don't try to fetch account balances for SS58-style accounts on moonbeam/moonriver
alecdwm
force-pushed
the
fix/minimetadatas-remap-lookup-ids
branch
from
aaad040
to
24a4199
Compare
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is an install script?Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts. Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead. What is protestware?This package is a joke, parody, or includes undocumented or hidden behavior unrelated to its primary function. Consider that consuming this package my come along with functionality unrelated to its primary purpose. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
A small aperitif to the main course.
This PR removes the need to patch
TypeRegistryby applying additionalmetadata -> miniMetadatamanipulation.Previous miniMetadatas
New miniMetadatas
I've also included a few small balances bugfixes as separate commits.